Attachment 222501 Details for Bug 253567 – Fixes compiler warnings in the source *.c files.

[patch] Fixes compiler warnings in the source *.c files.

fix-cc-warnings.diff (text/plain), 1.91 KB, created by Walter von Entferndt on 2021-02-16 19:23:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Walter von Entferndt

Created: 2021-02-16 19:23:28 UTC

Size: 1.91 KB

patch

obsolete

>--- files/patch-log.c.orig	2021-02-16 17:31:28.700036000 +0000
>+++ files/patch-log.c	2021-02-16 17:38:42.797755000 +0000
>@@ -0,0 +1,10 @@
>+--- log.c.orig	2000-06-22 22:55:13 UTC
>++++ log.c
>+@@ -37,6 +37,7 @@
>+ #include <unistd.h>
>+ #include <syslog.h>
>+ #include <stdio.h>
>++#include <stdlib.h>
>+ #include <stdarg.h>
>+ #include <errno.h>
>+ #include <signal.h>
>--- files/patch-main.c.orig	2021-02-16 17:31:28.702371000 +0000
>+++ files/patch-main.c	2021-02-16 17:38:42.801755000 +0000
>@@ -0,0 +1,10 @@
>+--- main.c.orig	2000-06-22 22:58:07 UTC
>++++ main.c
>+@@ -24,6 +24,7 @@
>+ 
>+ #include <time.h>
>+ #include <stdio.h>
>++#include <stdlib.h>
>+ #include <unistd.h>
>+ #include <signal.h>
>+ #include <fcntl.h>
>--- files/patch-matchrx.c.orig	2021-02-08 17:53:07.333214000 +0000
>+++ files/patch-matchrx.c	2021-02-16 17:38:42.805734000 +0000
>@@ -1,6 +1,6 @@
> --- matchrx.c.orig	2000-06-20 23:12:18 UTC
> +++ matchrx.c
>-@@ -23,6 +23,7 @@
>+@@ -23,9 +23,11 @@
>  
>  
>  #include <stdio.h>
>@@ -8,3 +8,7 @@
>  #include <regex.h>
>  #include <stdarg.h>
>  #include <stdlib.h>
>++#include <string.h>
>+ #include "matchrx.h"
>+ 
>+ int
>--- files/patch-runjob.c.orig	2021-02-08 17:53:07.333494000 +0000
>+++ files/patch-runjob.c	2021-02-16 17:38:42.813796000 +0000
>@@ -9,8 +9,6 @@
> -    int fd, i;
> +    int fd;
> +    char name[] = "/tmp/anacron.XXXXXX";
>-+
>-+    fd = mkstemp(name);
>  
> -    i = 0;
> -    name = NULL;
>@@ -25,10 +23,21 @@
> -	/* I'm not sure we actually need to be so persistent here */
> -    } while (fd == -1 && errno == EEXIST && i < max_retries);
> -    
>++    fd = mkstemp(name);
>++
>      if (fd == -1) die_e("Can't open temporary file");
>      if (unlink(name)) die_e("Can't unlink temporary file");
> -    free(name);
> +
>      fcntl(fd, F_SETFD, 1);    /* set close-on-exec flag */
>      return fd;
>+ }
>+@@ -84,7 +72,7 @@ username()
>+ }
>+ 
>+ static void
>+-xputenv(const char *s)
>++xputenv(char *s)
>+ {
>+     if (putenv(s)) die_e("Can't set the environment");
>  }

Flags:

walter.von.entferndt: maintainer-approval? (walter.von.entferndt)

Actions: View | Diff

Attachments on bug 253567: 222499 | 222500 | 222501 | 222554 | 223000