Removed
Link Here
|
1 |
From c24a0f852489124fa002bdc90b5753547899b1cb Mon Sep 17 00:00:00 2001 |
2 |
From: =?UTF-8?q?Krzysztof=20Ma=C5=82ysa?= <varqox@gmail.com> |
3 |
Date: Tue, 16 Feb 2021 18:46:06 +0100 |
4 |
Subject: [PATCH] compilers: clang: Drop -Xclang before -fcolor-diagnostics |
5 |
flag |
6 |
|
7 |
Using -Xclang -fcolor-diagnostics provides no advantage to using just -fcolor-diagnostics option and sometimes causes problems: |
8 |
* uncolored diagnostics on Arch Linux: https://bugs.archlinux.org/task/69662 |
9 |
* simple problem with removing flag -fcolor-diagnostics: https://github.com/clangd/clangd/issues/279 |
10 |
--- mesonbuild/compilers/mixins/clang.py.orig 2021-02-20 13:17:16 UTC |
11 |
+++ mesonbuild/compilers/mixins/clang.py |
12 |
@@ -29,9 +29,9 @@ if T.TYPE_CHECKING: |
13 |
from ...dependencies import Dependency # noqa: F401 |
14 |
|
15 |
clang_color_args = { |
16 |
- 'auto': ['-Xclang', '-fcolor-diagnostics'], |
17 |
- 'always': ['-Xclang', '-fcolor-diagnostics'], |
18 |
- 'never': ['-Xclang', '-fno-color-diagnostics'], |
19 |
+ 'auto': ['-fcolor-diagnostics'], |
20 |
+ 'always': ['-fcolor-diagnostics'], |
21 |
+ 'never': ['-fno-color-diagnostics'], |
22 |
} # type: T.Dict[str, T.List[str]] |
23 |
|
24 |
clang_optimization_args = { |