Attachment 225510 Details for Bug 256390 – [PATCH] boot loader: Fix __elfN(loadimage) return value

[patch] [PATCH] boot loader: Fix __elfN(loadimage) return value

0001-boot-loader-Fix-__elfN-loadimage-return-value.patch (text/plain), 1.01 KB, created by David Sebek on 2021-06-02 20:00:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Sebek

Created: 2021-06-02 20:00:47 UTC

Size: 1.01 KB

patch

obsolete

>From 02ffe41fc73563d0da88ecbc0534fe0e5f0bd895 Mon Sep 17 00:00:00 2001
>From: David Sebek <dasebek@gmail.com>
>Date: Wed, 2 Jun 2021 09:50:37 -0400
>Subject: [PATCH] boot loader: Fix __elfN(loadimage) return value
>
>Caller functions expect __elfN(loadimage) to return
>a value of zero on failure and a file size on success.
>Returning ENOENT on failure does not seem correct to me.
>
>Signed-off-by: David Sebek <dasebek@gmail.com>
>---
> stand/common/load_elf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/stand/common/load_elf.c b/stand/common/load_elf.c
>index 8bb780ef34d..f1a9ff8e0c2 100644
>--- a/stand/common/load_elf.c
>+++ b/stand/common/load_elf.c
>@@ -893,7 +893,7 @@ __elfN(loadimage)(struct preloaded_file *fp, elf_file_t ef, uint64_t off)
> 	p_start = sym.st_value + ef->off;
> 	if (__elfN(lookup_symbol)(ef, "__stop_set_modmetadata_set", &sym,
> 	    STT_NOTYPE) != 0)
>-		return ENOENT;
>+		return 0;
> 	p_end = sym.st_value + ef->off;
> 
> 	if (__elfN(parse_modmetadata)(fp, ef, p_start, p_end) == 0)
>-- 
>2.31.1
>

Actions: View | Diff

Attachments on bug 256390: 225510