View | Details | Raw Unified | Return to bug 255647 | Differences between
and this patch

Collapse All | Expand All

(-)b/mail/Makefile (-1 lines)
Lines 468-474 Link Here
468
    SUBDIR += postfinger
468
    SUBDIR += postfinger
469
    SUBDIR += postfix
469
    SUBDIR += postfix
470
    SUBDIR += postfix-current
470
    SUBDIR += postfix-current
471
    SUBDIR += postfix-current-sasl
472
    SUBDIR += postfix-ldap-sasl
471
    SUBDIR += postfix-ldap-sasl
473
    SUBDIR += postfix-logwatch
472
    SUBDIR += postfix-logwatch
474
    SUBDIR += postfix-policyd-sf
473
    SUBDIR += postfix-policyd-sf
(-)a/mail/postfix-current-sasl/Makefile (-12 lines)
Removed Link Here
1
PKGNAMESUFFIX?=	-current-sasl
2
3
MAINTAINER=	otis@FreeBSD.org
4
COMMENT=	Postfix with Cyrus SASL support
5
6
MASTERDIR=	${.CURDIR}/../postfix-current
7
8
OPTIONS_SLAVE=	SASL
9
10
SASL_SLAVE=	yes
11
12
.include "${MASTERDIR}/Makefile"
(-)b/mail/postfix-current/Makefile (-91 / +112 lines)
Lines 13-80 MASTER_SITES= http://ftp.porcupine.org/mirrors/postfix-release/ \ Link Here
13
		ftp://postfix.mirrors.pair.com/
13
		ftp://postfix.mirrors.pair.com/
14
MASTER_SITES:=	${MASTER_SITES:S|$|experimental/|}
14
MASTER_SITES:=	${MASTER_SITES:S|$|experimental/|}
15
#MASTER_SITES:=	${MASTER_SITES:S|$|official/|}
15
#MASTER_SITES:=	${MASTER_SITES:S|$|official/|}
16
PKGNAMESUFFIX?=	-current
16
PKGNAMESUFFIX=	-current
17
DIST_SUBDIR=	${PORTNAME}
17
DIST_SUBDIR=	${PORTNAME}
18
18
19
MAINTAINER=	otis@FreeBSD.org
19
MAINTAINER=	otis@FreeBSD.org
20
COMMENT=	Experimental Postfix version
20
COMMENT=	Experimental Postfix version ${COMMENT_${FLAVOR}}
21
21
22
LICENSE=	IPL10 EPL
22
LICENSE=	EPL IPL10
23
LICENSE_COMB=	multi
23
LICENSE_COMB=	multi
24
LICENSE_FILE=	${WRKSRC}/LICENSE
25
LICENSE_NAME_IPL10=	IBM PUBLIC LICENSE VERSION 1.0
24
LICENSE_NAME_IPL10=	IBM PUBLIC LICENSE VERSION 1.0
25
LICENSE_FILE=	${WRKSRC}/LICENSE
26
LICENSE_PERMS_IPL10=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept
26
LICENSE_PERMS_IPL10=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept
27
27
28
CONFLICTS_INSTALL?=	courier-0.* opensmtpd-[0-9]* sendmail-8.* sendmail+*-8.* \
28
FLAVORS=			default ldap sasl
29
		postfix35-* postfix-3.* postfix-base-3.* postfix-sasl-3.*
29
default_CONFLICTS_INSTALL=	postfix-current-base-ldap-* \
30
				postfix-current-base-sasl-* \
31
				postfix-current-ldap-* postfix-current-sasl-*
32
ldap_PKGNAMESUFFIX=		-current-ldap
33
ldap_CONFLICTS_INSTALL=		postfix-current-[0-9]* \
34
				postfix-current-base-[0-9] \
35
				postfix-current-base-sasl-* \
36
				postfix-current-sasl-*
37
sasl_PKGNAMESUFFIX=		-current-sasl
38
sasl_CONFLICTS_INSTALL=		postfix-current-[0-9]* \
39
				postfix-current-base-[0-9] \
40
				postfix-current-base-ldap-* \
41
				postfix-current-ldap-*
42
43
COMMENT_ldap=	(with OpenLDAP and Cyrus SASL support)
44
COMMENT_sasl=	(with Cyrus SASL support)
45
46
USES=		cpe shebangfix ssl
47
USE_RC_SUBR=	postfix
48
USE_SUBMAKE=	yes
30
49
31
USERS=		postfix
32
GROUPS=		mail maildrop postfix
33
USES=		shebangfix cpe ssl
34
SHEBANG_FILES=	auxiliary/qshape/qshape.pl
50
SHEBANG_FILES=	auxiliary/qshape/qshape.pl
35
51
36
USE_RC_SUBR=	postfix
37
USE_SUBMAKE=	yes
38
SCRIPTS_ENV+=	POSTFIX_DEFAULT_MTA="${POSTFIX_DEFAULT_MTA}"
52
SCRIPTS_ENV+=	POSTFIX_DEFAULT_MTA="${POSTFIX_DEFAULT_MTA}"
39
53
40
OPTIONS_SUB=	yes
54
CONFLICTS_INSTALL=	courier-0.* opensmtpd-[0-9]* opensmtpd-devel-* \
41
OPTIONS_DEFINE=	BDB BLACKLISTD CDB DOCS EAI INST_BASE LDAP \
55
			postfix-[0-9]* postfix-base-* postfix-ldap-sasl-* \
42
		LMDB MYSQL NIS PCRE PGSQL SASL SQLITE TEST TLS
56
			postfix-sasl-* postfix35-* sendmail-[0-9]* \
57
			sendmail-devel-*
43
58
44
OPTIONS_RADIO=		RG1
59
USERS=		postfix
45
OPTIONS_RADIO_RG1=	SASLKRB5 SASLKMIT
60
GROUPS=		mail maildrop postfix
61
62
OPTIONS_DEFINE=		BDB BLACKLISTD CDB DOCS EAI INST_BASE LDAP LMDB MYSQL \
63
			NIS PCRE PGSQL SASL SQLITE TEST TLS
46
OPTIONS_DEFAULT?=	BLACKLISTD EAI PCRE TLS
64
OPTIONS_DEFAULT?=	BLACKLISTD EAI PCRE TLS
65
OPTIONS_RADIO=		RG1
66
OPTIONS_RADIO_RG1=	SASLKMIT SASLKRB5
67
.if ${FLAVOR:U} == ldap
68
OPTIONS_SLAVE=		LDAP
69
.elif ${FLAVOR:U} == sasl
70
OPTIONS_SLAVE=		SASL
71
.endif
72
OPTIONS_SUB=		yes
47
73
48
BDB_USES=		bdb
74
.if !empty(FLAVOR) && ${FLAVOR:U} != default
49
BLACKLISTD_EXTRA_PATCHES=	${FILESDIR}/extra-patch-blacklistd
75
OPTIONS_FILE=	${PORT_DBDIR}/${OPTIONS_NAME}/${FLAVOR}-options
50
CDB_LIB_DEPENDS=	libcdb.so:databases/tinycdb
76
.endif
51
EAI_LIB_DEPENDS=	libicuuc.so:devel/icu
52
LDAP_USE=		OPENLDAP=yes
53
LMDB_LIB_DEPENDS=	liblmdb.so:databases/lmdb
54
MYSQL_USES?=		mysql
55
PCRE_LIB_DEPENDS=	libpcre.so:devel/pcre
56
PGSQL_USES=		pgsql
57
SASLKMIT_LIB_DEPENDS=	libkrb5.so:security/krb5
58
SASL_LIB_DEPENDS=	libsasl2.so:security/cyrus-sasl2
59
SQLITE_USES=		sqlite
60
77
61
BLACKLISTD_DESC=	Enable blacklistd support
78
BLACKLISTD_DESC=	Enable blacklistd support
62
CDB_DESC=	CDB maps lookups
79
CDB_DESC=		CDB maps lookups
63
EAI_DESC=	Email Address Internationalization (SMTPUTF8) support
80
EAI_DESC=		Email Address Internationalization (SMTPUTF8) support
64
INST_BASE_DESC=	Install into /usr and /etc/postfix
81
INST_BASE_DESC=		Install into /usr and /etc/postfix
65
LDAP_DESC=	LDAP maps (uses WITH_OPENLDAP_VER)
82
LDAP_DESC=		LDAP maps (uses WITH_OPENLDAP_VER)
66
LMDB_DESC=	LMDB maps
83
LMDB_DESC=		LMDB maps
67
TEST_DESC=	SMTP/LMTP test server and generator
84
RG1_DESC=		Kerberos network authentication protocol type
68
85
SASLKMIT_DESC=		If your SASL req. MIT Kerberos5, select this
69
SASL_DESC=	Cyrus SASL support (Dovecot SASL is always built in)
86
SASLKRB5_DESC=		If your SASL req. Kerberos5, select this
70
RG1_DESC=	Kerberos network authentication protocol type
87
SASL_DESC=		Cyrus SASL support (Dovecot SASL is always built in)
71
SASLKRB5_DESC=	If your SASL req. Kerberos5, select this
88
TEST_DESC=		SMTP/LMTP test server and generator
72
SASLKMIT_DESC=	If your SASL req. MIT Kerberos5, select this
89
90
BDB_USES=			bdb
91
BLACKLISTD_EXTRA_PATCHES=	${FILESDIR}/extra-patch-blacklistd
92
CDB_LIB_DEPENDS=		libcdb.so:databases/tinycdb
93
EAI_LIB_DEPENDS=		libicuuc.so:devel/icu
94
LDAP_USE=			OPENLDAP=yes
95
LMDB_LIB_DEPENDS=		liblmdb.so:databases/lmdb
96
MYSQL_USES?=			mysql
97
PCRE_LIB_DEPENDS=		libpcre.so:devel/pcre
98
PGSQL_USES=			pgsql
99
SASLKMIT_LIB_DEPENDS=		libkrb5.so:security/krb5
100
SASL_LIB_DEPENDS=		libsasl2.so:security/cyrus-sasl2
101
SQLITE_USES=			sqlite
73
102
74
.include <bsd.port.options.mk>
103
.include <bsd.port.options.mk>
75
104
76
HTML1=	body_checks.5.html bounce.5.html postfix-power.png \
105
HTML1=		body_checks.5.html bounce.5.html postfix-power.png \
77
	scache.8.html tlsmgr.8.html
106
		scache.8.html tlsmgr.8.html
78
107
79
STRIP_LIBEXEC=	anvil bounce cleanup discard dnsblog error flush lmtp local \
108
STRIP_LIBEXEC=	anvil bounce cleanup discard dnsblog error flush lmtp local \
80
		master nqmgr oqmgr pickup pipe postlogd postscreen proxymap \
109
		master nqmgr oqmgr pickup pipe postlogd postscreen proxymap \
Lines 88-99 MAKEFILEFLAGS+= DEBUG= Link Here
88
MAKEFILEFLAGS+=	pie=yes CC="${CC}" OPT="${CFLAGS}"
117
MAKEFILEFLAGS+=	pie=yes CC="${CC}" OPT="${CFLAGS}"
89
118
90
.if ${SSL_DEFAULT} == libressl
119
.if ${SSL_DEFAULT} == libressl
91
BROKEN=		error: OpenSSL-1.1.1 is the minimum supported version. \
120
BROKEN=		error: OpenSSL-1.1.1 is the minimum supported version. LibreSSL is not supported
92
		LibreSSL is not supported
93
.endif
121
.endif
94
122
95
.if ${PORT_OPTIONS:MINST_BASE}
123
.if ${PORT_OPTIONS:MINST_BASE}
96
.if defined(SASL_SLAVE)
124
.if ${FLAVOR:U} == ldap
125
PKGNAMESUFFIX=	-current-base-ldap
126
.elif ${FLAVOR:U} == sasl
97
PKGNAMESUFFIX=	-current-base-sasl
127
PKGNAMESUFFIX=	-current-base-sasl
98
.else
128
.else
99
PKGNAMESUFFIX=	-current-base
129
PKGNAMESUFFIX=	-current-base
Lines 109-117 PLIST_SUB+= PFETC=${ETCDIR} Link Here
109
139
110
# check if mailwrapper supports $LOCALBASE
140
# check if mailwrapper supports $LOCALBASE
111
.if ${OPSYS} == FreeBSD
141
.if ${OPSYS} == FreeBSD
112
SUB_LIST+=	USE_LOCALBASE_MAILER_CONF="yes" MC_PREFIX="${LOCALBASE}"
142
SUB_LIST+=	MC_PREFIX="${LOCALBASE}" \
143
		USE_LOCALBASE_MAILER_CONF="yes"
113
.else
144
.else
114
SUB_LIST+=	USE_LOCALBASE_MAILER_CONF="no" MC_PREFIX=""
145
SUB_LIST+=	MC_PREFIX="" \
146
		USE_LOCALBASE_MAILER_CONF="no"
115
.endif
147
.endif
116
148
117
.if ${PORT_OPTIONS:MDOCS}
149
.if ${PORT_OPTIONS:MDOCS}
Lines 122-155 READMEDIR= no Link Here
122
.endif
154
.endif
123
155
124
# dynamic direcory location
156
# dynamic direcory location
125
DAEMONDIR=	${PREFIX}/libexec/postfix
157
DAEMONDIR=		${PREFIX}/libexec/postfix
126
SHLIB_DIRECTORY=${PREFIX}/lib/postfix
158
SHLIB_DIRECTORY=	${PREFIX}/lib/postfix
127
# new proposed location is ETCDIR (see README_FILES/INSTALL)
159
# new proposed location is ETCDIR (see README_FILES/INSTALL)
128
# keep compatiblity with Postfix 2.6 .. 2.11 and use DAEMOMDIR
160
# keep compatiblity with Postfix 2.6 .. 2.11 and use DAEMOMDIR
129
META_DIRECTORY=	${DAEMONDIR}
161
META_DIRECTORY=		${DAEMONDIR}
130
162
131
SUB_LIST+=	REQUIRE="${_REQUIRE}" READMEDIR="${READMEDIR}" \
163
SUB_LIST+=	DAEMONDIR="${DAEMONDIR}" \
132
		DAEMONDIR="${DAEMONDIR}" META_DIRECTORY="${META_DIRECTORY}"
164
		META_DIRECTORY="${META_DIRECTORY}" \
133
SUB_FILES+=	pkg-install pkg-message mailer.conf.postfix
165
		READMEDIR="${READMEDIR}" \
134
166
		REQUIRE="${_REQUIRE}"
135
POSTFIX_CCARGS+=	-DDEF_CONFIG_DIR=\\\"${ETCDIR}\\\" \
167
SUB_FILES+=	mailer.conf.postfix pkg-install pkg-message
136
			-DDEF_DAEMON_DIR=\\\"${DAEMONDIR}\\\" \
168
137
			-DDEF_META_DIR=\\\"${META_DIRECTORY}\\\" \
169
POSTFIX_CCARGS+=	-DDEF_CONFIG_DIR=\\\"${ETCDIR}\\\" -DDEF_DAEMON_DIR=\\\"${DAEMONDIR}\\\" -DDEF_META_DIR=\\\"${META_DIRECTORY}\\\" -DDEF_COMMAND_DIR=\\\"${PREFIX}/sbin\\\" -DDEF_SENDMAIL_PATH=\\\"${PREFIX}/sbin/sendmail\\\" -DDEF_NEWALIAS_PATH=\\\"${PREFIX}/bin/newaliases\\\" -DDEF_MAILQ_PATH=\\\"${PREFIX}/bin/mailq\\\" -DDEF_MANPAGE_DIR=\\\"${MANPREFIX}/man\\\" -DDEF_README_DIR=\\\"${READMEDIR}\\\" -DDEF_HTML_DIR=\\\"${READMEDIR}\\\" -DDEF_QUEUE_DIR=\\\"/var/spool/postfix\\\" -DDEF_DATA_DIR=\\\"/var/db/postfix\\\" -DDEF_MAIL_OWNER=\\\"postfix\\\" -DDEF_SGID_GROUP=\\\"maildrop\\\" -Wmissing-prototypes -Wformat -Wno-comment
138
			-DDEF_COMMAND_DIR=\\\"${PREFIX}/sbin\\\" \
139
			-DDEF_SENDMAIL_PATH=\\\"${PREFIX}/sbin/sendmail\\\" \
140
			-DDEF_NEWALIAS_PATH=\\\"${PREFIX}/bin/newaliases\\\" \
141
			-DDEF_MAILQ_PATH=\\\"${PREFIX}/bin/mailq\\\" \
142
			-DDEF_MANPAGE_DIR=\\\"${MANPREFIX}/man\\\" \
143
			-DDEF_README_DIR=\\\"${READMEDIR}\\\" \
144
			-DDEF_HTML_DIR=\\\"${READMEDIR}\\\" \
145
			-DDEF_QUEUE_DIR=\\\"/var/spool/postfix\\\" \
146
			-DDEF_DATA_DIR=\\\"/var/db/postfix\\\" \
147
			-DDEF_MAIL_OWNER=\\\"postfix\\\" \
148
			-DDEF_SGID_GROUP=\\\"maildrop\\\" \
149
			-Wmissing-prototypes -Wformat -Wno-comment
150
170
151
# Default requirement for postfix rc script
171
# Default requirement for postfix rc script
152
_REQUIRE=		LOGIN cleanvar dovecot
172
_REQUIRE=	LOGIN cleanvar dovecot
153
173
154
# always build with Dovecot SASL support, Cyrus is optional
174
# always build with Dovecot SASL support, Cyrus is optional
155
# see Postfix HISTORY 20051222
175
# see Postfix HISTORY 20051222
Lines 172-189 POSTFIX_CCARGS+= -DNO_PCRE Link Here
172
.endif
192
.endif
173
193
174
.if ${PORT_OPTIONS:MSASL}
194
.if ${PORT_OPTIONS:MSASL}
175
POSTFIX_CCARGS+=	-DUSE_CYRUS_SASL -I${LOCALBASE}/include -I${LOCALBASE}/include/sasl
195
POSTFIX_CCARGS+=	-DUSE_CYRUS_SASL -I${LOCALBASE}/include \
196
			-I${LOCALBASE}/include/sasl
176
POSTFIX_AUXLIBS+=	-L${LOCALBASE}/lib -lsasl2 -lpam -lcrypt
197
POSTFIX_AUXLIBS+=	-L${LOCALBASE}/lib -lsasl2 -lpam -lcrypt
177
.else
198
.else
178
POSTFIX_CCARGS+=	-DDEF_SERVER_SASL_TYPE=\\\"dovecot\\\"
199
POSTFIX_CCARGS+=	-DDEF_SERVER_SASL_TYPE=\\\"dovecot\\\"
179
.endif
200
.endif
180
201
181
.if ${PORT_OPTIONS:MSASLKRB5}
202
.if ${PORT_OPTIONS:MSASLKRB5}
182
POSTFIX_AUXLIBS+=	-lkrb5 -lhx509 -lcrypto -lcrypt -lcom_err -lasn1 -lroken
203
POSTFIX_AUXLIBS+=	-lkrb5 -lhx509 -lcrypto -lcrypt -lcom_err -lasn1 \
204
			-lroken
183
.endif
205
.endif
184
206
185
.if ${PORT_OPTIONS:MSASLKMIT}
207
.if ${PORT_OPTIONS:MSASLKMIT}
186
POSTFIX_AUXLIBS+=	-Wl,--rpath,$${KRB5_HOME:-${LOCALBASE}}/lib -lkrb5 -lcrypto -lcrypt -lcom_err
208
POSTFIX_AUXLIBS+=	-Wl,--rpath,$${KRB5_HOME:-${LOCALBASE}}/lib -lkrb5 \
209
			-lcrypto -lcrypt -lcom_err
187
.endif
210
.endif
188
211
189
.if ${PORT_OPTIONS:MTLS}
212
.if ${PORT_OPTIONS:MTLS}
Lines 203-209 POSTFIX_AUXLIBS+= -L${BDB_LIB_DIR} -l${BDB_LIB_NAME} Link Here
203
. if ${OPSYS} == FreeBSD
226
. if ${OPSYS} == FreeBSD
204
POSTFIX_AUXLIBS+=	-lblacklist
227
POSTFIX_AUXLIBS+=	-lblacklist
205
. else
228
. else
206
IGNORE=	blacklistd is only supported on FreeBSD
229
IGNORE=		blacklistd is only supported on FreeBSD
207
. endif
230
. endif
208
.endif
231
.endif
209
232
Lines 232-239 DYN_EXT+= ldap Link Here
232
. if defined(WITH_OPENLDAP_VER)
255
. if defined(WITH_OPENLDAP_VER)
233
WANT_OPENLDAP_VER=	${WITH_OPENLDAP_VER}
256
WANT_OPENLDAP_VER=	${WITH_OPENLDAP_VER}
234
. endif
257
. endif
235
POSTFIX_CCARGS+=	-DHAS_LDAP -I${LOCALBASE}/include
258
POSTFIX_CCARGS+=	-DHAS_LDAP -I${LOCALBASE}/include \
236
POSTFIX_CCARGS+=	-I${LOCALBASE}/include/sasl -DUSE_LDAP_SASL
259
			-I${LOCALBASE}/include/sasl -DUSE_LDAP_SASL
237
POSTFIX_DYN_AUXLIBS+=	"AUXLIBS_LDAP=-L${LOCALBASE}/lib -lldap -L${LOCALBASE}/lib -llber"
260
POSTFIX_DYN_AUXLIBS+=	"AUXLIBS_LDAP=-L${LOCALBASE}/lib -lldap -L${LOCALBASE}/lib -llber"
238
_REQUIRE+=		slapd
261
_REQUIRE+=		slapd
239
.endif
262
.endif
Lines 261-280 POSTFIX_DYN_AUXLIBS+= "AUXLIBS_LMDB=-L${LOCALBASE}/lib -llmdb" Link Here
261
.endif
284
.endif
262
285
263
# sed script for files in ${WRKSRC}/README_FILES ${WRKSRC}/conf ${WRKSRC}/man
286
# sed script for files in ${WRKSRC}/README_FILES ${WRKSRC}/conf ${WRKSRC}/man
264
REINPLACE=	s!^PATH=.*!PATH=/bin:/sbin:/usr/bin:/usr/sbin:${PREFIX}/bin:${PREFIX}/sbin!;\
287
REINPLACE=	s!^PATH=.*!PATH=/bin:/sbin:/usr/bin:/usr/sbin:${PREFIX}/bin:${PREFIX}/sbin!; \
265
		s!(_directory = )/usr/!\1${PREFIX}/!g;\
288
		s!(_directory = )/usr/!\1${PREFIX}/!g; s!^(data_directory = \
266
		s!^(data_directory = /var/)lib/!\1db/!g;\
289
		/var/)lib/!\1db/!g; s!^\#(mynetworks_style = host)!\1!g; \
267
		s!^\#(mynetworks_style = host)!\1!g;\
290
		s!^(sendmail_path =)!\1 ${PREFIX}/sbin/sendmail!g; \
268
		s!^(sendmail_path =)!\1 ${PREFIX}/sbin/sendmail!g;\
291
		s!^(newaliases_path =)!\1 ${PREFIX}/bin/newaliases!g; \
269
		s!^(newaliases_path =)!\1 ${PREFIX}/bin/newaliases!g;\
292
		s!^(mailq_path =)!\1 ${PREFIX}/bin/mailq!g; s!^(setgid_group \
270
		s!^(mailq_path =)!\1 ${PREFIX}/bin/mailq!g;\
293
		=)!\1 maildrop!g; s!^(manpage_directory =)!\1 \
271
		s!^(setgid_group =)!\1 maildrop!g;\
294
		${MANPREFIX}/man!g; s!^((html|readme)_directory =)!\1 \
272
		s!^(manpage_directory =)!\1 ${MANPREFIX}/man!g;\
295
		${READMEDIR}!g; \!^\#alias_database = \
273
		s!^((html|readme)_directory =)!\1 ${READMEDIR}!g;\
296
		dbm:/etc/mail/aliases$$!d; s!(:|= \
274
		\!^\#alias_database = dbm:/etc/mail/aliases$$!d;\
297
		)/etc/postfix!\1$$config_directory!g; \
275
		s!(:|= )/etc/postfix!\1$$config_directory!g;\
298
		s!/etc/postfix!${ETCDIR}!g; s!^(sample_directory =)!\1 \
276
		s!/etc/postfix!${ETCDIR}!g;\
299
		${ETCDIR}!g; \
277
		s!^(sample_directory =)!\1 ${ETCDIR}!g;\
278
		s!($config_directory/(access|aliases|canonical|generic|header_checks|relocated|transport|virtual):f:root:-:644:)p1!\1o!;
300
		s!($config_directory/(access|aliases|canonical|generic|header_checks|relocated|transport|virtual):f:root:-:644:)p1!\1o!;
279
301
280
pre-patch:
302
pre-patch:
281
- 

Return to bug 255647