FreeBSD Bugzilla – Attachment 228517 Details for
Bug 259005
Mk/Scripts/qa.sh: Spurious SONAME warnings due to pipefail
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
qa_soname_pipefail.diff
qa_soname_pipefail.diff (text/plain), 973 bytes, created by
Henrik Gulbrandsen
on 2021-10-08 13:07:38 UTC
(
hide
)
Description:
qa_soname_pipefail.diff
Filename:
MIME Type:
Creator:
Henrik Gulbrandsen
Created:
2021-10-08 13:07:38 UTC
Size:
973 bytes
patch
obsolete
>diff --git a/Mk/Scripts/qa.sh b/Mk/Scripts/qa.sh >index 13548ddb38..e37e4167ec 100644 >--- a/Mk/Scripts/qa.sh >+++ b/Mk/Scripts/qa.sh >@@ -663,7 +663,7 @@ proxydeps() { > > # Check that the .so we need has a SONAME > if [ "${dep_file_pkg}" != "${PKGORIGIN}" ]; then >- if ! readelf -d "${dep_file}" | grep -q SONAME; then >+ if ! (set +o pipefail; readelf -d "${dep_file}" | grep -q SONAME); then > err "${file} is linked to ${dep_file} which does not have a SONAME. ${dep_file_pkg} needs to be fixed." > fi > fi >@@ -713,7 +713,7 @@ sonames() { > [ -z "${f}" ] && continue > # Ignore symlinks > [ -f "${f}" -a ! -L "${f}" ] || continue >- if ! readelf -d ${f} | grep -q SONAME; then >+ if ! (set +o pipefail; readelf -d ${f} | grep -q SONAME); then > warn "${f} doesn't have a SONAME." > warn "pkg(8) will not register it as being provided by the port." > warn "If another port depend on it, pkg will not be able to know where it comes from."
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=228517">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 259005
: 228517