Attachment 231114 Details for Bug 261226 – Patch for core/src/dird/catreq.cc eliminates a write-only variable named size

[patch] Patch for core/src/dird/catreq.cc eliminates a write-only variable named size

patch-core_src_dird_catreq.cc (text/plain), 1.05 KB, created by Trond Endrestøl on 2022-01-18 09:47:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Trond Endrestøl

Created: 2022-01-18 09:47:58 UTC

Size: 1.05 KB

patch

obsolete

>--- core/src/dird/catreq.cc.orig	2021-12-21 11:00:49 UTC
>+++ core/src/dird/catreq.cc
>@@ -656,7 +656,7 @@ bool DespoolAttributesFromFile(JobControlRecord* jcr, 
>   bool retval = false;
>   int32_t pktsiz;
>   size_t nbytes;
>-  ssize_t size = 0;
>+  //ssize_t size = 0; // sysutils/bareos-server/work/bareos-Release-21.0.0/core/src/dird/catreq.cc:659:11: error: variable 'size' set but not used [-Werror,-Wunused-but-set-variable]
>   int32_t message_length; /* message length */
>   int spool_fd = -1;
>   POOLMEM* msg = GetPoolMemory(PM_MESSAGE);
>@@ -680,7 +680,7 @@ bool DespoolAttributesFromFile(JobControlRecord* jcr, 
> 
>   while ((nbytes = read(spool_fd, (char*)&pktsiz, sizeof(int32_t)))
>          == sizeof(int32_t)) {
>-    size += sizeof(int32_t);
>+    //size += sizeof(int32_t);
>     message_length = ntohl(pktsiz);
> 
>     if (message_length > 0) {
>@@ -697,7 +697,7 @@ bool DespoolAttributesFromFile(JobControlRecord* jcr, 
>         goto bail_out;
>       }
>       msg[nbytes] = '\0';
>-      size += nbytes;
>+      //size += nbytes;
>     }
> 
>     if (!jcr->IsJobCanceled()) {

Actions: View | Diff

Attachments on bug 261226: 231114