Attachment 238134 Details for Bug 267825 – Patch for collectors/freebsd.plugin/freebsd_sysctl.c

[patch] Patch for collectors/freebsd.plugin/freebsd_sysctl.c

patch-collectors_freebsd.plugin_freebsd__sysctl.c (text/plain), 2.88 KB, created by Trond Endrestøl on 2022-11-17 08:51:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Trond Endrestøl

Created: 2022-11-17 08:51:29 UTC

Size: 2.88 KB

patch

obsolete

>path: root/sys/netinet/tcp_var.h
>
>author	Richard Scheffenegger <rscheff@FreeBSD.org>	2022-11-10 10:35:02 +0000
>committer	Richard Scheffenegger <rscheff@FreeBSD.org>	2022-11-10 10:35:35 +0000
>commit	1a70101a870015304d5b2446b480d8677d8aad36 (patch)
>tree	09085296f212fa1eb150a8f1a04484c2a10da1cc /sys/netinet/tcp_var.h
>parent	8526120ad41ca47367b43f8f4459e0fa61285571 (diff)
>download	src-1a70101a870015304d5b2446b480d8677d8aad36.tar.gz
>src-1a70101a870015304d5b2446b480d8677d8aad36.zip
>
>tcp: account sent/received IP ECN markings independently
>Have tcpstats (netstat -s) differentiate between received and sent
>ECN-marked packets. Also account for IP ECN bits (on TCP packets)
>even when the tcp session has not negotiated ECN support.
>
>Event:			IETF 115 Hackathon
>Reviewed By:		glebius, tuexen, #transport
>Sponsored by:		NetApp, Inc.
>Differential Revision:	https://reviews.freebsd.org/D37314
>
>--- collectors/freebsd.plugin/freebsd_sysctl.c.orig	2022-08-15 13:53:51 UTC
>+++ collectors/freebsd.plugin/freebsd_sysctl.c
>@@ -2140,9 +2140,9 @@ int do_net_inet_tcp_stats(int update_every, usec_t dt)
>             // --------------------------------------------------------------------
> 
>             if (do_ecn == CONFIG_BOOLEAN_YES || (do_ecn == CONFIG_BOOLEAN_AUTO &&
>-                                                 (tcpstat.tcps_ecn_ce ||
>-                                                  tcpstat.tcps_ecn_ect0 ||
>-                                                  tcpstat.tcps_ecn_ect1 ||
>+                                                 (tcpstat.tcps_ecn_rcvce ||
>+                                                  tcpstat.tcps_ecn_rcvect0 ||
>+                                                  tcpstat.tcps_ecn_rcvect1 ||
>                                                   netdata_zero_metrics_enabled == CONFIG_BOOLEAN_YES))) {
>                 do_ecn = CONFIG_BOOLEAN_YES;
> 
>@@ -2174,11 +2174,11 @@ int do_net_inet_tcp_stats(int update_every, usec_t dt)
>                 }
>                 else rrdset_next(st);
> 
>-                rrddim_set_by_pointer(st, rd_ce,     tcpstat.tcps_ecn_ce);
>-                rrddim_set_by_pointer(st, rd_no_ect, tcpstat.tcps_ecn_ce - (tcpstat.tcps_ecn_ect0 +
>-                                                                            tcpstat.tcps_ecn_ect1));
>-                rrddim_set_by_pointer(st, rd_ect0,   tcpstat.tcps_ecn_ect0);
>-                rrddim_set_by_pointer(st, rd_ect1,   tcpstat.tcps_ecn_ect1);
>+                rrddim_set_by_pointer(st, rd_ce,     tcpstat.tcps_ecn_rcvce);
>+                rrddim_set_by_pointer(st, rd_no_ect, tcpstat.tcps_ecn_rcvce - (tcpstat.tcps_ecn_rcvect0 +
>+                                                                            tcpstat.tcps_ecn_rcvect1));
>+                rrddim_set_by_pointer(st, rd_ect0,   tcpstat.tcps_ecn_rcvect0);
>+                rrddim_set_by_pointer(st, rd_ect1,   tcpstat.tcps_ecn_rcvect1);
>                 rrdset_done(st);
>             }
>

Actions: View | Diff

Attachments on bug 267825: 238134