FreeBSD Bugzilla – Attachment 249947 Details for
Bug 278343
x11/tint: Fix crashes caused by conky
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
git patch with the update
0001-Fix-crash-caused-by-conky-sending-events-tied-to-the.patch (text/plain), 1.61 KB, created by
yamagi
on 2024-04-13 08:49:03 UTC
(
hide
)
Description:
git patch with the update
Filename:
MIME Type:
Creator:
yamagi
Created:
2024-04-13 08:49:03 UTC
Size:
1.61 KB
patch
obsolete
>From 814e263fd251e93ed3383256c5724a54b91b141b Mon Sep 17 00:00:00 2001 >From: Yamagi <yamagi@yamagi.org> >Date: Sat, 13 Apr 2024 10:27:37 +0200 >Subject: [PATCH] Fix crash caused by conky sending events tied to the root > windows. > >For some reasing recent versions of conky send X11 events of type hover, >press and release tied to the root window and not an actual window. This >uncovers a long standing bug in tint: tint tries to determine the panel >associated with the root window, this is always NULL. Dereferencing the >NULL pointer crashes tint. Work around this by not handling such events. >--- > x11/tint/Makefile | 2 +- > x11/tint/files/patch-src_main.c | 12 ++++++++++++ > 2 files changed, 13 insertions(+), 1 deletion(-) > create mode 100644 x11/tint/files/patch-src_main.c > >diff --git a/x11/tint/Makefile b/x11/tint/Makefile >index 2c1b19430723..2cf2fb3289ee 100644 >--- a/x11/tint/Makefile >+++ b/x11/tint/Makefile >@@ -1,6 +1,6 @@ > PORTNAME= tint2 > PORTVERSION= 16.7 >-PORTREVISION= 4 >+PORTREVISION= 5 > CATEGORIES= x11 > > MAINTAINER= yamagi@yamagi.org >diff --git a/x11/tint/files/patch-src_main.c b/x11/tint/files/patch-src_main.c >new file mode 100644 >index 000000000000..085c8ffc3580 >--- /dev/null >+++ b/x11/tint/files/patch-src_main.c >@@ -0,0 +1,12 @@ >+--- src/main.c.orig 2024-04-13 07:17:11 UTC >++++ src/main.c >+@@ -419,6 +419,9 @@ void handle_x_event(XEvent *e) >+ if (handle_x_event_autohide(e)) >+ return; >+ >++ if ((e->type==4 || e->type==5 || e->type==6) && e->xproperty.window==server.root_win) >++ return; >++ >+ Panel *panel = get_panel(e->xany.window); >+ switch (e->type) { >+ case ButtonPress: { >-- >2.44.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
yamagi:
maintainer-approval+
Actions:
View
|
Diff
Attachments on
bug 278343
: 249947