Attachment 5322 Details for Bug 12801 – file.dat

file.dat

file.dat (text/plain; charset=us-ascii), 1.98 KB, created by mheffner on 2001-08-15 04:59:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: mheffner

Created: 2001-08-15 04:59:12 UTC

Size: 1.98 KB

patch

obsolete

>Forwarding to audit-trail.
>
>-----FW: <20010814234350.A52363@unknown.whichever.org>-----
>
>Date: Tue, 14 Aug 2001 23:43:50 -0400
>From: Alexander Litvin <archer@whichever.org>
>To: Sheldon Hearn <sheldonh@starjuice.net>
>Subject: Re: bin/12801: nvi infinite recursion with options "leftright" and
>"comment"
>Cc: mikeh@FreeBSD.org
>
>> In message about "Re: bin/12801: nvi infinite recursion with options
>"leftright" and "comment""
>>  on Fri, Jul 06, 2001, at 08:48:09 AM you wrote:
>> 
>> > > Synopsis: nvi infinite recursion with options "leftright" and "comment"
>> > > 
>> > > State-Changed-From-To: suspended->feedback
>> > > State-Changed-By: mikeh
>> > > State-Changed-When: Thu Jul 5 17:26:35 PDT 2001
>> > > State-Changed-Why: 
>> > > Is this fixed with the patch in bin/28687?
>> > 
>> > Should be. :-)
>> 
>> No, unfortunately it's not.
>
>Actually, as I investigated the problem, it is more severe
>then just using to incompatible options. That is, this
>infinite recursion can be "achieved" even without "comment"
>option -- it is enougth, for example, to do the following:
>
>1) go to the line with number NUM, where
>   1 < NUM < "screen height"/2;
>2) make the line to be on the top of the screen
>   (e.g. by z+<Enter>);
>3) do :e <non-existent file>
>
>What I figured is that during switching files vi somehow
>messes up the old and new state -- like sp (pointer to
>screen structure?) already contains (mostly) info about
>new file, but HMAP macro (what's this exactly?) still
>has information about old file position. The fact that
>this mess really works through vs_refresh() is, IMHO,
>accidential.
>
>The attached patch seems to fix the problem. This is sort
>of hack, because I don't exactly understand the guts of vi,
>and I have no idea how produce politically correct fix.
>But at least it doesn't do anything bad (IMHO).
>
>--- 
>Laugh at your problems; everybody else does.
>
>
>--------------End of forwarded message-------------------------
>
>
>Mike
>
>-- 
>  Mike Heffner         <mheffner@[acm.]vt.edu>
>  Fredericksburg, VA       <mikeh@FreeBSD.org>

Actions: View

Attachments on bug 12801: 5322 | 5323 | 5324