Attachment 58018 Details for Bug 87498 – file.diff

[patch] file.diff

file.diff (text/plain), 1.43 KB, created by Bill Fenner on 2005-10-16 00:30:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bill Fenner

Created: 2005-10-16 00:30:11 UTC

Size: 1.43 KB

patch

obsolete

>Index: src/portlint.pl
>===================================================================
>RCS file: /home/ncvs/ports/devel/portlint/src/portlint.pl,v
>retrieving revision 1.76
>diff -u -r1.76 portlint.pl
>--- src/portlint.pl	9 Oct 2005 18:52:58 -0000	1.76
>+++ src/portlint.pl	14 Oct 2005 18:55:52 -0000
>@@ -1188,13 +1188,32 @@
> 	}
> 
> 	#
>-	# whole file: BROKEN
>+	# whole file: BROKEN et al.
> 	#
>-	print "OK: checking BROKEN.\n" if ($verbose);
>-	if ($whole =~ /\nBROKEN[+?]?=[ \t][^"]+\w+/) {
>+	my($var);
>+	foreach $var qw(BROKEN FORBIDDEN MANUAL_PACKAGE_BUILD NO_CDROM NO_PACKAGE RESTRICTED) {
>+		print "OK: checking ${var}.\n" if ($verbose);
>+		if ($whole =~ /\n${var}[+?]?=[ \t]?[^"]+\w+/) {
>+			my $lineno = &linenumber($`);
>+			&perror("WARN: $file [$lineno]: ${var} messages should be ".
>+				"quoted.");
>+		}
>+	}
>+
>+	#
>+	# whole file: DEPRECATED
>+	#
>+	print "OK: checking DEPRECATED.\n" if ($verbose);
>+	if ($whole =~ /\nDEPRECATED[+?]?=[ \t]*"/ &&
>+	    $whole !~ /\nDEPRECATED[+?]?=[ \t]*"\$\{BROKEN\}"/) {
>+		my $lineno = &linenumber($`);
>+		&perror("WARN: $file [$lineno]: DEPRECATED messages should not ".
>+			"be quoted unless they are exactly \"\${BROKEN}\".");
>+	}
>+	if ($whole =~ /\nDEPRECATED[+?]?=[^"]*\$\{BROKEN\}/) {
> 		my $lineno = &linenumber($`);
>-		&perror("WARN: $file [$lineno]: BROKEN messages should be ".
>-			"quoted.");
>+		&perror("WARN: $file [$lineno]: \"\${BROKEN}\" must be quoted ".
>+			"when it is the source of DEPRECATED.");
> 	}
> 
> 	#

Actions: View | Diff

Attachments on bug 87498: 58018