|
Removed
Link Here
|
| 1 |
--- fuse_module/fuse_vnops.c Sat Jul 14 13:14:27 2007 |
| 2 |
+++ fuse_module/fuse_vnops.c Sat Jul 14 13:14:27 2007 |
| 3 |
@@ -42,6 +42,10 @@ |
| 4 |
#include "fuse_vnode.h" |
| 5 |
#include "fuse_io.h" |
| 6 |
|
| 7 |
+#if USE_PRIVILEGE_API |
| 8 |
+#include <sys/priv.h> |
| 9 |
+#endif |
| 10 |
+ |
| 11 |
/* function prototype for iterators over filehandles (of a vp) */ |
| 12 |
typedef int fuse_metrics_t(struct vnode *vp, struct thread *td, |
| 13 |
struct ucred *cred, struct fuse_filehandle *fufh, |
| 14 |
@@ -63,7 +67,9 @@ struct fuse_access_param { |
| 15 |
#define FACCESS_CHOWN 0x08 /* do permission check for owner changing */ |
| 16 |
#define FACCESS_NOCHECKSPY 0x10 /* don't check if daemon is allowed to spy on |
| 17 |
user */ |
| 18 |
-#define FACCESS_XQUERIES FACCESS_STICKY | FACCESS_CHOWN |
| 19 |
+#define FACCESS_SETGID 0x12 /* do permission check for setting setgid flag */ |
| 20 |
+ |
| 21 |
+#define FACCESS_XQUERIES FACCESS_STICKY | FACCESS_CHOWN | FACCESS_SETGID |
| 22 |
|
| 23 |
#define FVP_ACCESS_NOOP 0x01 /* vnode based control flag for doing access check */ |
| 24 |
|
| 25 |
@@ -855,6 +861,7 @@ fuse_access(ap) |
| 26 |
|
| 27 |
/* |
| 28 |
* Attribute caching hasn't yet been implemented. |
| 29 |
+ * [... Update: it _has been_ implemented.] |
| 30 |
* However, within one function we don't wanna query attributes |
| 31 |
* several times. Now it's enough pull the attributes once, and throw |
| 32 |
* it into the following routine with various modes. |
| 33 |
@@ -929,12 +936,16 @@ fuse_access_i(struct vnode *vp, mode_t m |
| 34 |
mode == VWRITE) { |
| 35 |
if (cred->cr_uid != facp->xuid && |
| 36 |
cred->cr_uid != VTOVA(vp)->va_uid) |
| 37 |
- err = suser_cred(cred, SUSER_ALLOWJAIL); |
| 38 |
+ err = priv_check_cred(cred, |
| 39 |
+ PRIV_VFS_ADMIN, |
| 40 |
+ 0); |
| 41 |
} |
| 42 |
/* |
| 43 |
* We return here because this flags is exlusive |
| 44 |
* with the others |
| 45 |
*/ |
| 46 |
+ KASSERT(facp->facc_flags == FACCESS_STICKY, |
| 47 |
+ ("sticky access check comes in mixed")); |
| 48 |
return (err); |
| 49 |
} |
| 50 |
|
| 51 |
@@ -947,10 +958,21 @@ fuse_access_i(struct vnode *vp, mode_t m |
| 52 |
(cred->cr_gid != facp->xgid && |
| 53 |
facp->xgid != (gid_t)VNOVAL && |
| 54 |
! groupmember(facp->xgid, cred))) |
| 55 |
- err = suser_cred(cred, SUSER_ALLOWJAIL); |
| 56 |
- return (err); |
| 57 |
+ err = priv_check_cred(cred, PRIV_VFS_CHOWN, 0); |
| 58 |
+ if (err) |
| 59 |
+ return (err); |
| 60 |
} |
| 61 |
|
| 62 |
+ if (facp->facc_flags & FACCESS_SETGID) { |
| 63 |
+ gid_t sgid = facp->xgid; |
| 64 |
+ |
| 65 |
+ if (sgid == (gid_t)VNOVAL) |
| 66 |
+ sgid = VTOVA(vp)->va_gid; |
| 67 |
+ |
| 68 |
+ if (! groupmember(sgid, cred)) |
| 69 |
+ err = priv_check_cred(cred, PRIV_VFS_SETGID, 0); |
| 70 |
+ return (err); |
| 71 |
+ } |
| 72 |
|
| 73 |
} else { |
| 74 |
#if FUSE_HAS_ACCESS |
| 75 |
@@ -1234,7 +1256,13 @@ fuse_lookup(ap) |
| 76 |
*/ |
| 77 |
if (nameiop == RENAME && wantparent && islastcn) { |
| 78 |
DEBUG("something to rename...\n"); |
| 79 |
- if ((err = fuse_access_i(dvp, VWRITE, cred, td, &facp))) |
| 80 |
+ |
| 81 |
+ facp.xuid = fattr->uid; |
| 82 |
+ facp.facc_flags |= FACCESS_STICKY; |
| 83 |
+ err = fuse_access_i(dvp, VWRITE, cred, td, &facp); |
| 84 |
+ facp.facc_flags &= ~FACCESS_XQUERIES; |
| 85 |
+ |
| 86 |
+ if (err) |
| 87 |
goto out; |
| 88 |
|
| 89 |
/* |
| 90 |
@@ -2948,8 +2976,14 @@ fuse_setattr(ap) |
| 91 |
} |
| 92 |
|
| 93 |
if (vap->va_mode != (mode_t)VNOVAL) { |
| 94 |
+#if _DEBUG |
| 95 |
if (vap->va_mode & S_IFMT) |
| 96 |
- DEBUG("fuse_setattr -- weird: format bits in mode field, 0%o\n", vap->va_mode); |
| 97 |
+ DEBUG("fuse_setattr -- weird: " |
| 98 |
+ "format bits in mode field, 0%o\n", |
| 99 |
+ vap->va_mode); |
| 100 |
+#endif |
| 101 |
+ if (vap->va_mode & S_ISGID) |
| 102 |
+ facp.facc_flags |= FACCESS_SETGID; |
| 103 |
fsai->FUSEATTR(mode) = vap->va_mode & ALLPERMS; |
| 104 |
fsai->valid |= FATTR_MODE; |
| 105 |
} |
| 106 |
|