From 601cd8355609580f914c27e15c25bbee25219f6d Mon Sep 17 00:00:00 2001 From: Eygene Ryabinkin Date: Thu, 27 Nov 2008 23:04:40 +0300 Very old portaudit.xml in ports-mgmt/portaudit-db/database has 4 years old entry for samba that renders current port, net/samba32-devel to be marked as vulnerable. This happens due to the bad version specification that spans over port epoches, thus caching samba32-devel that has no portepoch: ----- $ pkg_version -T samba-3.2.4 'samba>=3.*<3.0.5,1' && echo Found! Found! ----- Applied modification fixes the things, ----- $ pkg_version -T samba-3.2.4 'samba>=3.*<3.0a20' && echo Found! $ pkg_version -T samba-3.2.4 'samba>=3.0.0.b1,1<3.0.5,1' && echo Found! ----- and seem to catch originally intended versions properly: ----- $ pkg_version -T samba-3.0a19 'samba>=3.*<3.0a20' && echo Found! Found! $ pkg_version -T samba-3.0a19 'samba>=3.0.0.b1,1<3.0.5,1' && echo Found! $ pkg_version -T samba-3.0.1,1 'samba>=3.0.0.b1,1<3.0.5,1' && echo Found! Found! $ pkg_version -T samba-3.0.1,1 'samba>=3.*<3.0a20' && echo Found! ----- Samba revision history was traced by using CVS logs, http://www.freebsd.org/cgi/cvsweb.cgi/ports/net/samba3/Makefile Particularily, portepoch was bumped at the Makefile's version 1.92: http://www.freebsd.org/cgi/cvsweb.cgi/ports/net/samba3/Makefile.diff?r1=1.91;r2=1.92 Note well: the added port specification will catch version 3.0.20, for example, ----- $ pkg_version -T samba-3.0.20 'samba>=3.*<3.0a20' && echo Found! Found! ----- but FreeBSD's 3.0.20 is be named '3.0.20,1', so we seem to be safe here, since this particular specification will catch only 3.0.x: ----- $ pkg_version -T samba-3.1.32 'samba>=3.*<3.0a20' && echo Found! ----- Signed-off-by: Eygene Ryabinkin --- ports-mgmt/portaudit-db/database/portaudit.xml | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/ports-mgmt/portaudit-db/database/portaudit.xml b/ports-mgmt/portaudit-db/database/portaudit.xml index 168072a..bcae088 100644 --- a/ports-mgmt/portaudit-db/database/portaudit.xml +++ b/ports-mgmt/portaudit-db/database/portaudit.xml @@ -287,7 +287,8 @@ EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. samba - 3.*3.0.5,1 + 3.0.0.b1,13.0.5,1 + 3.*3.0a20 2.2.10 -- 1.6.0.4