FreeBSD Bugzilla – Attachment 99477 Details for
Bug 138557
[patch] fix truncated witness sysctl string due to incorrect use of sizeof
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
file.diff
file.diff (text/plain), 947 bytes, created by
Rebecca Cran
on 2009-09-05 22:00:13 UTC
(
hide
)
Description:
file.diff
Filename:
MIME Type:
Creator:
Rebecca Cran
Created:
2009-09-05 22:00:13 UTC
Size:
947 bytes
patch
obsolete
>--- subr_witness.c.orig 2009-09-05 21:24:40.000000000 +0100 >+++ subr_witness.c 2009-09-05 21:25:42.000000000 +0100 >@@ -2378,11 +2378,11 @@ > tmp_w1 = NULL; > tmp_w2 = NULL; > if (witness_watch < 1) { >- error = SYSCTL_OUT(req, w_notrunning, sizeof(w_notrunning)); >+ error = SYSCTL_OUT(req, w_notrunning, strlen(w_notrunning) + 1); > return (error); > } > if (witness_cold) { >- error = SYSCTL_OUT(req, w_stillcold, sizeof(w_stillcold)); >+ error = SYSCTL_OUT(req, w_stillcold, strlen(w_stillcold) + 1); > return (error); > } > error = 0; >@@ -2530,11 +2530,11 @@ > int error; > > if (witness_watch < 1) { >- error = SYSCTL_OUT(req, w_notrunning, sizeof(w_notrunning)); >+ error = SYSCTL_OUT(req, w_notrunning, strlen(w_notrunning) + 1); > return (error); > } > if (witness_cold) { >- error = SYSCTL_OUT(req, w_stillcold, sizeof(w_stillcold)); >+ error = SYSCTL_OUT(req, w_stillcold, strlen(w_stillcold) + 1); > return (error); > } > error = 0;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=99477">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 138557
: 99477