212782 2016-09-18 03:37:29 +0000 [bhyve] Increasing VM_MAXCPU to >= 26 will result in ACPI MADT table corruption 2019-05-04 13:49:00 +0000 1 1 1 Unclassified Base System kern CURRENT amd64 Any Closed FIXED --- Affects Some People --- 1 grehan rgrimes araujo olevole rgrimes seanc trentnthompson virtualization oldest_to_newest 898265 0 grehan 2016-09-18 03:37:29 +0000 From the email sent to the freebsd-virtualization list, subject "High vCPU Counts in bhyve" https://lists.freebsd.org/pipermail/freebsd-virtualization/2016-September/004721.html The cause and fix was described in a follow-on post: https://lists.freebsd.org/pipermail/freebsd-virtualization/2016-September/004724.html This PR will track the fix. 998519 1 linimon 2018-06-21 07:08:40 +0000 Return to the mailing list. 998525 2 araujo 2018-06-21 07:27:23 +0000 I will take it. 1030700 3 araujo 2019-01-08 16:59:31 +0000 For reference, this ticket is being discussed on this review: https://reviews.freebsd.org/D18755 1031285 4 rgrimes 2019-01-11 01:12:00 +0000 (In reply to Marcelo Araujo from comment #3) A proposed fix is now available in https://reviews.freebsd.org/D18815 1048641 5 commit-hook 2019-04-25 22:53:45 +0000 A commit references this bug: Author: rgrimes Date: Thu Apr 25 22:52:44 UTC 2019 New revision: 346715 URL: https://svnweb.freebsd.org/changeset/base/346715 Log: Acpi MADT table correction for VM_MAXCPU > 21 The bhyve acpi MADT table was given a static space of 256 (0x100) bytes, this is enough space to allow VM_MAXCPU to be 21, this patch changes that so VM_MAXCPU can be of arbitrary value and not overflow the space by actually calculating the space needed for the table. PR: 212782 Reviewed by: Patrick Mooney <patrick.mooney@joyent.com> Approved by: bde (mentor), jhb (maintainer) MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D18815 Changes: head/usr.sbin/bhyve/acpi.c 1049677 6 commit-hook 2019-05-04 13:44:23 +0000 A commit references this bug: Author: rgrimes Date: Sat May 4 13:43:49 UTC 2019 New revision: 347124 URL: https://svnweb.freebsd.org/changeset/base/347124 Log: MFC: r346715: Acpi MADT table correction for VM_MAXCPU > 21 The bhyve acpi MADT table was given a static space of 256 (0x100) bytes, this is enough space to allow VM_MAXCPU to be 21, this patch changes that so VM_MAXCPU can be of arbitrary value and not overflow the space by actually calculating the space needed for the table. PR: 212782 Reviewed by: Patrick Mooney <patrick.mooney@joyent.com> Approved by: bde (mentor, implicit), jhb (maintainer) Differential Revision: https://reviews.freebsd.org/D18815 Changes: _U stable/11/ stable/11/usr.sbin/bhyve/acpi.c _U stable/12/ stable/12/usr.sbin/bhyve/acpi.c