230813 2018-08-22 08:07:35 +0000 ftp/lftp: 4.8.4 fails to build 2018-08-27 11:09:41 +0000 1 1 1 Unclassified Ports & Packages Individual Port(s) Latest Any Any Closed FIXED --- Affects Some People --- 1 pascal.christen martymac freebsd pascal.christen sgs simon.wright spambox w.schwarzenfeld oldest_to_newest 1007788 0 196438 pascal.christen 2018-08-22 08:07:35 +0000 Created attachment 196438 lftp build output Hi After Update to 4.8.4, lftp failed to build with freebsd10.4 &6 11.2 1007979 1 196470 martymac 2018-08-23 10:16:38 +0000 Created attachment 196470 Add missing -pthread 1007981 2 martymac 2018-08-23 10:17:37 +0000 Hi Pascal, Thanks for your report. I think your are trying to build lftp with GnuTLS (it builds fine with OpenSSL). Can you try the attached patch and tell me if it fixes your problem ? Best regards, Ganael. 1007984 3 pascal.christen 2018-08-23 10:31:08 +0000 (In reply to Ganael LAPLANCHE from comment #2) Hi No, I'm building with openssl (openssl-1.0.2p) too: ---Begin OPTIONS List--- ===> The following configuration options are available for lftp-4.8.4: DOCS=on: Build and/or install documentation NLS=on: Native Language Support ====> SSL protocol support: you can only select none or one of them OPENSSL=on: SSL/TLS support via OpenSSL GNUTLS=off: SSL/TLS support via GnuTLS ===> Use 'make config' to modify these settings ---End OPTIONS List--- --MAINTAINER-- martymac@FreeBSD.org --End MAINTAINER-- --CONFIGURE_ARGS-- --enable-nls --with-openssl --without-gnutls --prefix=/usr/local ${_LATE_CONFIGURE_ARGS} --End CONFIGURE_ARGS-- 1007998 4 spambox 2018-08-23 12:54:36 +0000 I can confirm that lftp builds with OpenSSL fail due to missing pthread. Poudriere log: https://poudriere.koumakan.jp/data/11amd64-default/2018-08-23_21h39m03s/logs/errors/lftp-4.8.4.log 1008054 5 196485 martymac 2018-08-23 21:24:54 +0000 Created attachment 196485 Add missing -pthread (take 2) 1008056 6 martymac 2018-08-23 21:30:59 +0000 Hi Kamigishi, Pascal, OK, you are using OpenSSL from *ports* while I was testing the build against OpenSSL from *base*. I can now reproduce the problem when using OpenSSL from ports (with 'DEFAULT_VERSIONS+= ssl=openssl' set in make.conf). Adding -pthread fixes the problem too. Can you try the more generic patch attached ? It now adds the missing -pthead flag unconditionally. 1008057 7 spambox 2018-08-23 21:39:44 +0000 It builds fine for me with OpenSSL from ports. I wonder if there is a way to properly tell if OpenSSL was built with multi-threading enabled, since it is likely wrong to link libthr if it is not. 1008060 8 spambox 2018-08-23 21:45:39 +0000 Seems “openssl version -f” will have -pthread for ports-built OpenSSL. The problem is that we would have to test for /usr/local/bin/openssl first, because base has PATH priority. Base OpenSSL's version -f shows just “clang”. The other, likely safer, option is to check “ldd /path/to/openssl” output for libthr.so. 1008086 9 sgs 2018-08-24 06:41:48 +0000 Note: The build fails also when DEFAULT_VERSIONS+= ssl=libressl 1008088 10 pascal.christen 2018-08-24 07:07:44 +0000 (In reply to Ganael LAPLANCHE from comment #6) > Can you try the more generic patch attached ? It now adds the missing -pthead flag unconditionally. This one works for me 1008115 11 martymac 2018-08-24 10:15:29 +0000 Hi, Thanks for your reports. I'll be working on a new version of the patch, stay tuned (ENOTIME right now, probably at the beginning of next week). Best regards, Ganael. 1008276 12 freebsd 2018-08-25 08:35:46 +0000 (In reply to Ganael LAPLANCHE from comment #6) It also fails with libressl from ports. 1008279 13 w.schwarzenfeld 2018-08-25 09:36:16 +0000 Libressl could be solved by adding: OPENSSL_CONFIGURE_ENV= LIBS=-pthread 1008595 14 commit-hook 2018-08-27 10:16:22 +0000 A commit references this bug: Author: martymac Date: Mon Aug 27 10:16:03 UTC 2018 New revision: 478188 URL: https://svnweb.freebsd.org/changeset/ports/478188 Log: Fix build when selected SSL library is linked to libthr When a non-default SSL library is used (GnuTLS, OpenSSL or LibreSSL from ports) and if it is linked to libthr, compilation fails with the following error : /usr/bin/ld: undefined reference to symbol `pthread_mutexattr_gettype@@FBSD_1.0' (try adding -lthr) //lib/libthr.so.3: could not read symbols: Bad value As OpenSSL-like ports (OpenSSL from base, OpenSSL and OpenSSL-devel from ports, LibreSSL and LibreSSL-devel from ports) may or may not be linked to libthr, fix build by detecting if the selected library is linked to libthr or not. PR: 230813 Submitted by: Pascal Christen <pascal.christen@hostpoint.ch> Changes: head/ftp/lftp/Makefile 1008601 15 martymac 2018-08-27 11:09:41 +0000 Should be fixed right now. Thanks for your report! 196438 2018-08-22 08:07:35 +0000 2018-08-22 08:07:35 +0000 lftp build output lftp_build.txt text/plain 1085 pascal.christen L2Jpbi9zaCAuLi9saWJ0b29sIC0tc2lsZW50ICAtLXRhZz1DWFggICAgLS1tb2RlPWxpbmsgYysr IC1zdGQ9Z251KysxMSAgIC1PMiAtcGlwZSAtZm5vLW9taXQtZnJhbWUtcG9pbnRlciAtRExJQklD T05WX1BMVUcgLWZzdGFjay1wcm90ZWN0b3IgLWlzeXN0ZW0gL3Vzci9sb2NhbC9pbmNsdWRlIC1m bm8tc3RyaWN0LWFsaWFzaW5nICAtRExJQklDT05WX1BMVUcgLWlzeXN0ZW0gL3Vzci9sb2NhbC9p bmNsdWRlIC1XYWxsIC1Xd3JpdGUtc3RyaW5ncyAtV292ZXJsb2FkZWQtdmlydHVhbCAtZm5vLWV4 Y2VwdGlvbnMgLWZuby1ydHRpIC1leHBvcnQtZHluYW1pYyAtV2wsLXJwYXRoLC91c3IvbG9jYWwv bGliIC1mc3RhY2stcHJvdGVjdG9yIC1vIGxmdHAgbGZ0cC1sZnRwLm8gbGZ0cC1jb21wbGV0ZS5v ICBsZnRwLWxmdHBfcmwubyBsZnRwLWF0dGFjaC5vIGxpYmxmdHAtam9icy5sYSBsaWJsZnRwLXRh c2tzLmxhIC1ML3Vzci9saWIgLWxyZWFkbGluZSAtbHV0aWwgLWx0aW5mbyAtTC91c3IvbG9jYWwv bGliIC1saWRuMgovdXNyL2Jpbi9sZDogdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBzeW1ib2wgYHB0 aHJlYWRfbXV0ZXhhdHRyX2dldHR5cGVAQEZCU0RfMS4wJyAodHJ5IGFkZGluZyAtbHRocikKLy9s aWIvbGlidGhyLnNvLjM6IGNvdWxkIG5vdCByZWFkIHN5bWJvbHM6IEJhZCB2YWx1ZQpjKys6IGVy cm9yOiBsaW5rZXIgY29tbWFuZCBmYWlsZWQgd2l0aCBleGl0IGNvZGUgMSAodXNlIC12IHRvIHNl ZSBpbnZvY2F0aW9uKQoqKiogRXJyb3IgY29kZSAxCgpTdG9wLgptYWtlWzNdOiBzdG9wcGVkIGlu IC93cmtkaXJzL3Vzci9wb3J0cy9mdHAvbGZ0cC93b3JrL2xmdHAtNC44LjQvc3JjCioqKiBFcnJv ciBjb2RlIDEKClN0b3AuCm1ha2VbMl06IHN0b3BwZWQgaW4gL3dya2RpcnMvdXNyL3BvcnRzL2Z0 cC9sZnRwL3dvcmsvbGZ0cC00LjguNAoqKiogRXJyb3IgY29kZSAxCgpTdG9wLgptYWtlWzFdOiBz dG9wcGVkIGluIC93cmtkaXJzL3Vzci9wb3J0cy9mdHAvbGZ0cC93b3JrL2xmdHAtNC44LjQKKioq IEVycm9yIGNvZGUgMQoKU3RvcC4KbWFrZTogc3RvcHBlZCBpbiAvdXNyL3BvcnRzL2Z0cC9sZnRw Cgo= 196470 2018-08-23 10:16:38 +0000 2018-08-23 21:24:54 +0000 Add missing -pthread patch-lftp.txt text/plain 387 martymac ZGlmZiAtYXVyTiBmdHAvbGZ0cC5vcmlnL01ha2VmaWxlIGZ0cC9sZnRwL01ha2VmaWxlCi0tLSBm dHAvbGZ0cC5vcmlnL01ha2VmaWxlCTIwMTgtMDgtMjEgMTI6MjU6MzEuMDM0OTU0MDAwICswMjAw CisrKyBmdHAvbGZ0cC9NYWtlZmlsZQkyMDE4LTA4LTIzIDEyOjEwOjIyLjI5MTAwNDAwMCArMDIw MApAQCAtNDMsNiArNDMsNyBAQAogT1BFTlNTTF9DT05GSUdVUkVfV0lUSD0Jb3BlbnNzbAogT1BF TlNTTF9VU0VTPQlzc2wKIEdOVVRMU19DT05GSUdVUkVfV0lUSD0JZ251dGxzCitHTlVUTFNfQ09O RklHVVJFX0VOVj0JTElCUz0tcHRocmVhZAogR05VVExTX0xJQl9ERVBFTkRTPQlsaWJnbnV0bHMu c286c2VjdXJpdHkvZ251dGxzCiBHTlVUTFNfVVNFUz0JcGtnY29uZmlnCiAK 196485 2018-08-23 21:24:54 +0000 2018-08-23 21:24:54 +0000 Add missing -pthread (take 2) patch-lftp.txt text/plain 415 martymac ZGlmZiAtYXVyTiBmdHAvbGZ0cC5vcmlnL01ha2VmaWxlIGZ0cC9sZnRwL01ha2VmaWxlCi0tLSBm dHAvbGZ0cC5vcmlnL01ha2VmaWxlCTIwMTgtMDgtMjEgMTI6MjU6MzEuMDM0OTU0MDAwICswMjAw CisrKyBmdHAvbGZ0cC9NYWtlZmlsZQkyMDE4LTA4LTIzIDIzOjEyOjU1LjA4OTI5ODAwMCArMDIw MApAQCAtMjQsNiArMjQsNyBAQAogCiBVU0VTPQkJY2hhcnNldGZpeCBpY29udiBsaWJ0b29sIGxv Y2FsYmFzZSByZWFkbGluZSBzaGViYW5nZml4CiBHTlVfQ09ORklHVVJFPQl5ZXMKK0xERkxBR1Mr PQktcHRocmVhZAogCiBQT1JURE9DUz0JQVVUSE9SUyBCVUdTIENoYW5nZUxvZyBGQVEgRkVBVFVS RVMgSU5TVEFMTCBcCiAJCU1JUlJPUlMgTkVXUyBSRUFETUUgUkVBRE1FLmRlYnVnLWxldmVscyBS RUFETUUubW9kdWxlcyBcCg==