248716 2020-08-18 06:49:35 +0000 ftp/lftp: 4.9.2 fails to build with libressl 2020-08-21 05:45:42 +0000 1 1 1 Unclassified Ports & Packages Individual Port(s) Latest Any Any Closed FIXED --- Affects Some People --- 1 sgs martymac lwhsu oldest_to_newest 1118562 0 sgs 2020-08-18 06:49:35 +0000 Libressl fails to build against libressl-3.1.3 with the following error: /bin/sh ../libtool --silent --tag=CXX --mode=compile c++ -DHAVE_CONFIG_H -I. -I../lib -I../lib -I../trio -I/usr/include -DLIBICONV_PLUG -I/usr/local/include -isystem /usr/local/include -D_THREAD_SAFE -O2 -pipe -fno-strict-aliasing -DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include -DLIBICONV_PLUG -isystem /usr/local/include -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -MT liblftp_network_la-lftp_ssl.lo -MD -MP -MF .deps/liblftp_network_la-lftp_ssl.Tpo -c -o liblftp_network_la-lftp_ssl.lo `test -f 'lftp_ssl.cc' || echo './'`lftp_ssl.cc lftp_ssl.cc:1164:10: error: use of undeclared identifier 'X509_STORE_CTX_get_by_subject'; did you mean 'X509_STORE_get_by_subject'? rc = X509_STORE_CTX_get_by_subject(store_ctx, X509_LU_CRL, subject, obj); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ X509_STORE_get_by_subject /usr/local/include/openssl/x509_vfy.h:479:5: note: 'X509_STORE_get_by_subject' declared here int X509_STORE_get_by_subject(X509_STORE_CTX *vs,int type,X509_NAME *name, ^ lftp_ssl.cc:1204:10: error: use of undeclared identifier 'X509_STORE_CTX_get_by_subject'; did you mean 'X509_STORE_get_by_subject'? rc = X509_STORE_CTX_get_by_subject(store_ctx, X509_LU_CRL, issuer, obj); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ X509_STORE_get_by_subject /usr/local/include/openssl/x509_vfy.h:479:5: note: 'X509_STORE_get_by_subject' declared here int X509_STORE_get_by_subject(X509_STORE_CTX *vs,int type,X509_NAME *name, ^ --- liblftp_network_la-Resolver.lo --- mv -f .deps/liblftp_network_la-Resolver.Tpo .deps/liblftp_network_la-Resolver.Plo --- liblftp_network_la-buffer_ssl.lo --- /bin/sh ../libtool --silent --tag=CXX --mode=compile c++ -DHAVE_CONFIG_H -I. -I../lib -I../lib -I../trio -I/usr/include -DLIBICONV_PLUG -I/usr/local/include -isystem /usr/local/include -D_THREAD_SAFE -O2 -pipe -fno-strict-aliasing -DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include -DLIBICONV_PLUG -isystem /usr/local/include -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -MT liblftp_network_la-buffer_ssl.lo -MD -MP -MF .deps/liblftp_network_la-buffer_ssl.Tpo -c -o liblftp_network_la-buffer_ssl.lo `test -f 'buffer_ssl.cc' || echo './'`buffer_ssl.cc --- liblftp_network_la-lftp_ssl.lo --- 2 errors generated. *** [liblftp_network_la-lftp_ssl.lo] Error code 1 make[4]: stopped in /usr/ports/ftp/lftp/work/lftp-4.9.2/src --- liblftp_network_la-NetAccess.lo --- mv -f .deps/liblftp_network_la-NetAccess.Tpo .deps/liblftp_network_la-NetAccess.Plo --- SSH_Access.lo --- mv -f .deps/SSH_Access.Tpo .deps/SSH_Access.Plo --- liblftp_network_la-buffer_ssl.lo --- mv -f .deps/liblftp_network_la-buffer_ssl.Tpo .deps/liblftp_network_la-buffer_ssl.Plo 1 error 1118933 1 martymac 2020-08-20 10:16:41 +0000 Hi Simeon, Thanks for your report. Compatibility with LibreSSL seems to have been broken upstream in commit 537f37898, see: https://github.com/lavv17/lftp/commit/537f37898 Can you test the attached patch please ? 1118934 2 217368 martymac 2020-08-20 10:17:10 +0000 Created attachment 217368 Fix LibreSSL support 1118951 3 sgs 2020-08-20 12:03:07 +0000 Hi and thank you for the patch! It fixed the build error for me. Best regards Simeon Simeonov 1119065 4 commit-hook 2020-08-21 05:42:32 +0000 A commit references this bug: Author: martymac Date: Fri Aug 21 05:42:16 UTC 2020 New revision: 545573 URL: https://svnweb.freebsd.org/changeset/ports/545573 Log: Fix build with LibreSSL PR: 248716 Submitted by: Simeon Simeonov <sgs@pichove.org> Changes: head/ftp/lftp/files/patch-src_lftp__ssl.cc 1119066 5 martymac 2020-08-21 05:45:42 +0000 Hello Simeon, The patch has been committed. Thanks for your feedback! Best regards, Ganael. 217368 2020-08-20 10:17:10 +0000 2020-08-20 10:17:10 +0000 Fix LibreSSL support patch-lftp-libressl.txt text/plain 1639 martymac SW5kZXg6IGZ0cC9sZnRwL2ZpbGVzL3BhdGNoLXNyY19sZnRwX19zc2wuY2MKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gZnRwL2xmdHAvZmlsZXMvcGF0Y2gtc3JjX2xmdHBfX3NzbC5jYwkobm9uZXhpc3RlbnQpCisr KyBmdHAvbGZ0cC9maWxlcy9wYXRjaC1zcmNfbGZ0cF9fc3NsLmNjCSh3b3JraW5nIGNvcHkpCkBA IC0wLDAgKzEsMjkgQEAKKy0tLSBzcmMvbGZ0cF9zc2wuY2Mub3JpZwkyMDIwLTAxLTI5IDIwOjM2 OjM3IFVUQworKysrIHNyYy9sZnRwX3NzbC5jYworQEAgLTM0LDcgKzM0LDcgQEAKKyAjaW5jbHVk ZSAibWlzYy5oIgorICNpbmNsdWRlICJuZXR3b3JrLmgiCisgI2luY2x1ZGUgImJ1ZmZlci5oIgor LSNpZiBPUEVOU1NMX1ZFUlNJT05fTlVNQkVSIDwgMHgxMDEwMDAwMEwKKysjaWYgT1BFTlNTTF9W RVJTSU9OX05VTUJFUiA8IDB4MTAxMDAwMDBMIHx8IExJQlJFU1NMX1ZFUlNJT05fTlVNQkVSCisg I2RlZmluZSBYNTA5X1NUT1JFX0NUWF9nZXRfYnlfc3ViamVjdCBYNTA5X1NUT1JFX2dldF9ieV9z dWJqZWN0CisgI2VuZGlmCisgZXh0ZXJuICJDIiB7CitAQCAtODQwLDcgKzg0MCw3IEBAIGxmdHBf c3NsX29wZW5zc2xfaW5zdGFuY2U6OmxmdHBfc3NsX29wZW5zc2xfaW5zdGFuY2UoKQorICAgIHNz bF9jdHg9U1NMX0NUWF9uZXcoKTsKKyAgICBYNTA5X3NldF9kZWZhdWx0X3ZlcmlmeV9wYXRocyhz c2xfY3R4LT5jZXJ0KTsKKyAjZWxzZQorLSNpZiBPUEVOU1NMX1ZFUlNJT05fTlVNQkVSIDwgMHgx MDEwMDAwMEwKKysjaWYgT1BFTlNTTF9WRVJTSU9OX05VTUJFUiA8IDB4MTAxMDAwMDBMIHx8IExJ QlJFU1NMX1ZFUlNJT05fTlVNQkVSCisgICAgU1NMZWF5X2FkZF9zc2xfYWxnb3JpdGhtcygpOwor ICNlbmRpZgorICAgIHNzbF9jdHg9U1NMX0NUWF9uZXcoU1NMdjIzX2NsaWVudF9tZXRob2QoKSk7 CitAQCAtMTA4MCw3ICsxMDgwLDcgQEAgdm9pZCBsZnRwX3NzbF9vcGVuc3NsOjpjb3B5X3NpZChj b25zdCBsZnRwX3NzbF9vcGVuc3NsCisgCisgY29uc3QgY2hhciAqbGZ0cF9zc2xfb3BlbnNzbDo6 c3RyZXJyb3IoKQorIHsKKy0jaWYgT1BFTlNTTF9WRVJTSU9OX05VTUJFUiA8IDB4MTAxMDAwMDBM CisrI2lmIE9QRU5TU0xfVkVSU0lPTl9OVU1CRVIgPCAweDEwMTAwMDAwTCB8fCBMSUJSRVNTTF9W RVJTSU9OX05VTUJFUgorICAgIFNTTF9sb2FkX2Vycm9yX3N0cmluZ3MoKTsKKyAjZW5kaWYKKyAg ICBpbnQgZXJyb3I9RVJSX2dldF9lcnJvcigpOwoKUHJvcGVydHkgY2hhbmdlcyBvbjogZnRwL2xm dHAvZmlsZXMvcGF0Y2gtc3JjX2xmdHBfX3NzbC5jYwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFkZGVkOiBmYnNkOm5v a2V5d29yZHMKIyMgLTAsMCArMSAjIworeWVzClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgcHJvcGVy dHkKQWRkZWQ6IHN2bjplb2wtc3R5bGUKIyMgLTAsMCArMSAjIworbmF0aXZlClwgTm8gbmV3bGlu ZSBhdCBlbmQgb2YgcHJvcGVydHkKQWRkZWQ6IHN2bjptaW1lLXR5cGUKIyMgLTAsMCArMSAjIwor dGV4dC9wbGFpbgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIHByb3BlcnR5Cg==