Bug 101328

Summary: [patch] games/tyrquake doesn't build on amd64.
Product: Ports & Packages Reporter: rsmith
Component: Individual Port(s)Assignee: Alejandro Pulver <alepulver>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description rsmith 2006-08-03 20:50:10 UTC
	tyrquake doesn't build on amd64. This is due to a bug in the
	makefile. The make environment flag NO_X86_ASM=YES is set when
	the WITHOUT_X86_ASM is _not_ set.

Fix: - Set WITHOUT_X86_ASM="yes" on every architecture != i386
- Fix the test.

See patch below:
-------- patch for /usr/ports/games/tyrquake/Makefile --------


Maybe this bug should be marked critical for all the quake addicts out
there? ;-)--I71ezUBCOcIJXAd8a3SGn9hwxW2kYLJzjA6JbSY8lTpSVyxM
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.orig	Thu Aug  3 21:25:51 2006
+++ Makefile	Thu Aug  3 21:36:54 2006
@@ -26,11 +26,15 @@
 
 .include <bsd.port.pre.mk>
 
+.if ${ARCH} != i386
+WITHOUT_X86_ASM="yes"
+.endif
+
 .if !defined(WITHOUT_OPTIMIZED_CFLAGS)
 MAKE_ENV+=	OPTIMIZED_CFLAGS=YES
 .endif
 
-.if !defined(WITHOUT_X86_ASM)
+.if defined(WITHOUT_X86_ASM)
 MAKE_ENV+=	NO_X86_ASM=YES
 .endif
 
-------- patch for /usr/ports/games/tyrquake/Makefile --------
How-To-Repeat: 	Try building the code with the option X86_ASM set to off on amd64.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-08-03 20:50:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->alepulver

Over to maintainer
Comment 2 Alejandro Pulver freebsd_committer freebsd_triage 2006-08-04 00:23:03 UTC
State Changed
From-To: open->closed

Committed (changes merged into the same line), thanks.