Bug 101352
| Summary: | [patch] devel/gsoap: FD_SETSIZE checking is wrong: some client apps dont work | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Šimun Mikecin <numisemis> | ||||
| Component: | Individual Port(s) | Assignee: | Sergey Matveychuk <sem> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | sem | ||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Responsible Changed From-To: freebsd-ports-bugs->sem Over to maintainer State Changed From-To: open->closed Committed. Thanks! Unfortunatelly with this commit it doesn't build on
6.x anymore. I suppose the problem is with this part
of the Makefile (which was not in the PR):
+.if ${OSVERSION} < 500000
+CONST=
+.else
+CONST= const
+.endif
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
|
gsoap 2.7.8c has file descriptor checking like this: if ((int)soap->socket > FD_SETSIZE) return SOAP_FD_EXCEEDED; /* Hint: MUST increase FD_SETSIZE */ and on FreeBSD FD_SETSIZE is defined in /usr/include/sys/select.h like this: #define FD_SETSIZE 1024U unlike many other systems where it doesn't have 'U' suffix which makes it an "unsigned" type. Problem is that comparing: if ((int) -1 > 1024U) returns true, so the function call fails, but it shouldn't cause soap->socket initially has a value of -1. I already reported this bug on the gsoap project tracker. How-To-Repeat: As a consequence of this bug, I have experienced that SOAP calls from client SOAP applications in some situations (like using HTTP keep-alive and one-way message parsing) return with SOAP_FD_EXCEEDED instead of SOAP_OK.