Summary: | [PATCH] Remove INSTALLS_SHLIB from ports | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | gslin |
Component: | Individual Port(s) | Assignee: | Cheng-Lung Sung <clsung> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | CC: | gslin |
Priority: | Normal | ||
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any |
Description
gslin
2006-08-12 12:40:13 UTC
Responsible Changed From-To: freebsd-ports-bugs->clsung clsung@ wanted to have these. Hm, please be careful with this: this patch introduced an error at least in databases/clip since LDCONFIG_DIRS was set. In that case, setting 'USE_LDCONFIG=yes' will force LDCONFIG_DIRS *back* *to* *the* *default* *value*, thus breaking the intended mechanism of runnung ldconfig on a custom directory. Is this analysis correct? Please identify the ports on your list that also set LDCONFIG_DIRS! Volker On Wed, Aug 30, 2006 at 12:38:05PM +0800, Volker Stolz wrote:
> Hm, please be careful with this: this patch introduced an error at
> least in databases/clip since LDCONFIG_DIRS was set. In that case,
> setting 'USE_LDCONFIG=yes' will force LDCONFIG_DIRS *back* *to* *the*
> *default* *value*, thus breaking the intended mechanism of runnung
> ldconfig on a custom directory.
>
> Is this analysis correct? Please identify the ports on your list that
> also set LDCONFIG_DIRS!
>
> Volker
Can I have the error log?
== copy from bsd.port.mk ==
.if defined(INSTALLS_SHLIB)
LDCONFIG_DIRS?= %%PREFIX%%/lib
LDCONFIG_PLIST!= ${ECHO_CMD} ${LDCONFIG_DIRS} | ${SED} ${PLIST_SUB:S/$/!g/:S/^/ -e s!%%/:S/=/%%!/}
LDCONFIG_RUNLIST!= ${ECHO_CMD} ${LDCONFIG_PLIST} | ${SED} -e "s!%D!${PREFIX}!g"
.endif
== end ==
In databases/clip, LDCONFIG_DIRS will become useless, maybe we should remove
it,too.
--
Cheng-Lung Sung - clsung@
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 30.08.2006, at 12:53, Cheng-Lung Sung wrote: > On Wed, Aug 30, 2006 at 12:38:05PM +0800, Volker Stolz wrote: >> Hm, please be careful with this: this patch introduced an error at >> least in databases/clip since LDCONFIG_DIRS was set. In that case, >> setting 'USE_LDCONFIG=yes' will force LDCONFIG_DIRS *back* *to* *the* >> *default* *value*, thus breaking the intended mechanism of runnung >> ldconfig on a custom directory. > > In databases/clip, LDCONFIG_DIRS will become useless, maybe we > should remove > it,too. Only if you Do The Right Thing, e.g. setting USE_LDCONFIG to the value now stored in LDCONFIG_DIRS (untested). - -- "In Macao ist alles besser!" http://lambda.foldr.org/~vs/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iQCVAwUBRPUbARLpPok/0ba1AQKpTwP7BDwsAF69infJg7D0Tydu6YO3n9O7aHt3 HvuGkF0S89JQaJbprkk1k7R+nNhpw4NyZj0jzHOZihg8n9G5NzlXsTFg3BnHTKeb I2rWevC6bohfggGIHzM4cxNTVeBQgunfqmh30sxbR1Y10tbv4e0bpvdBKPsHzBkl VXLTM0mgvMI= =ZCMI -----END PGP SIGNATURE----- State Changed From-To: open->closed Most ports are updated with USE_LDCONFIG. Others will be processed by maintainer. Thank you. |