Bug 102160

Summary:	EDITOR and PAGER not set correctly in fixit.profile
Product:	Base System	Reporter:	Thomas Quinot <thomas>
Component:	bin	Assignee:	kensmith
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Unspecified
Hardware:	Any
OS:	Any

Description Thomas Quinot 2006-08-16 21:50:18 UTC

	src/release/fixit.profile has:
	export EDITOR="/mnt2/stand/vi"
	export PAGER="/mnt2/stand/more"
	but these paths are invalid in the Fixit environment:
	/mnt2/stand is a symlink pointing to "/rescue", and there is no
	/rescue.

Fix: 

For EDITOR, I see at least three possible solutions:
	1. Change fixit.profile to set EDITOR to /mnt2/rescue/vi
	2. Have sysinstall create a symlink /rescue -> /mnt2/rescue.
	3. Change the /stand symlink to point to "rescue" (instead
	   of "/rescue").

	For PAGER, we have an additional issue: there is no "more" and no
	"less" either in /mnt2/rescue. We could possibly use
	PAGER=/mnt2/usr/bin/more, or else add "more" to the /rescue builtin
	utilities.
How-To-Repeat: 	Boot disc1.iso.
	Enter Fixit shell in CD-ROM mode.
	Use disklabel -e <some device>
	Observe error message:
	disklabel: /mnt2/stand/vi: No such file or directory

Comment 1 Thomas Quinot freebsd_committer

2006-08-24 12:07:25 UTC

Proposed patch attached.

Thomas.

Index: fixit.profile
===================================================================
RCS file: /space/mirror/ncvs/src/release/fixit.profile,v
retrieving revision 1.10
diff -u -r1.10 fixit.profile
--- fixit.profile	2 Sep 2004 13:40:34 -0000	1.10
+++ fixit.profile	24 Aug 2006 11:04:51 -0000
@@ -3,8 +3,8 @@
 
 export BLOCKSIZE=K
 export PS1="Fixit# "
-export EDITOR="/mnt2/stand/vi"
-export PAGER="/mnt2/stand/more"
+export EDITOR="/mnt2/rescue/vi"
+export PAGER="/mnt2/usr/bin/less"
 export SCSI_MODES="/mnt2/usr/share/misc/scsi_modes"
 # the root MFS doesn't have /dev/nrsa0, pick a better default for mt(1)
 export TAPE=/mnt2/dev/nrsa0

Comment 2 Thomas Quinot freebsd_committer

2006-08-24 12:12:36 UTC

Responsible Changed
From-To: freebsd-bugs->thomas

I'll take care of this one.

Comment 3 kensmith freebsd_committer

2008-01-22 15:42:45 UTC

Responsible Changed
From-To: thomas->kensmith


Working on this.

Comment 4 kensmith freebsd_committer

2008-02-03 05:12:53 UTC

State Changed
From-To: open->closed


Fixed in RELENG_7 and RELENG_6.