Bug 102413
| Summary: | Festival port makes build with ESD difficult | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | russo |
| Component: | Individual Port(s) | Assignee: | Mikhail Teterin <mi> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
russo
2006-08-23 02:00:32 UTC
State Changed From-To: open->feedback Awaiting maintainers feedback State Changed From-To: feedback->open Assign to maintainer Responsible Changed From-To: freebsd-ports-bugs->mi Assign to maintainer Hi, Thomas! Would you submit the patch, please? Thanks! -mi On Sun, Oct 08, 2006 at 10:25:33AM -0400, we recorded a bogon-computron collision of the <mi+kde@aldan.algebra.com> flavor, containing: > Hi, Thomas! > > Would you submit the patch, please? Thanks! I'm sorry, I don't think I know how to make a patch that would allow the full flexibility of turning esd support on or off. I was able to figure out how to kludge it so that esd support could be enabled --- it amounted to uncommenting one line in the one file I mentioned in the bug report and adding "esd" to the top-level Makefile's LIB_DEPENDS, but I wouldn't know how to apply that conditionally through the top-level makefile. -- Tom Russo KM5VY SAR502 DM64ux http://www.swcp.com/~russo/ Tijeras, NM QRPL#1592 K2#398 SOC#236 AHTB#1 http://kevan.org/brain.cgi?DDTNM "And, isn't sanity really just a one-trick pony anyway? I mean all you get is one trick, rational thinking, but when you're good and crazy, oooh, oooh, oooh, the sky is the limit!" --- The Tick On Tue, Oct 10, 2006 at 06:12:42AM -0600, we recorded a bogon-computron collision of the <russo@bogodyn.org> flavor, containing: > On Sun, Oct 08, 2006 at 10:25:33AM -0400, we recorded a bogon-computron collision of the <mi+kde@aldan.algebra.com> flavor, containing: > > Hi, Thomas! > > > > Would you submit the patch, please? Thanks! > > I'm sorry, I don't think I know how to make a patch that would allow the > full flexibility of turning esd support on or off. I was able to figure > out how to kludge it so that esd support could be enabled --- it amounted > to uncommenting one line in the one file I mentioned in the bug report and > adding "esd" to the top-level Makefile's LIB_DEPENDS, but I wouldn't know how > to apply that conditionally through the top-level makefile. For what it's worth, the 'festival+OGI' port has a patch file (patch-ad) that enables NAS and ESD support in that port. It was where I looked to figure out how to enable it in the vanilla festival port. If that patch is made unconditionally (as it used to be), then festival will require both NAS and ESD for building, which is probably too much bloat for most users' taste --- one generally doesn't use both at once, why require both? So ideally, the port should support WITH_NAS and WITH_ESD options, and have two alternate patch files similar to festival+OGI's patch-ad that are selected based on the chosen options. I don't know how to do that within FreeBSD's ports makefile set-up. -- Tom Russo KM5VY SAR502 DM64ux http://www.swcp.com/~russo/ Tijeras, NM QRPL#1592 K2#398 SOC#236 AHTB#1 http://kevan.org/brain.cgi?DDTNM "And, isn't sanity really just a one-trick pony anyway? I mean all you get is one trick, rational thinking, but when you're good and crazy, oooh, oooh, oooh, the sky is the limit!" --- The Tick צ×ÔÏÒÏË 10 ÖÏ×ÔÅÎØ 2006 08:30, Tom Russo ÎÁÐÉÓÁ×:
> For what it's worth, the 'festival+OGI' port has a patch file (patch-ad)
> that enables NAS and ESD support in that port. It was where I looked to
> figure out how to enable it in the vanilla festival port.
Sorry, Tom, but port-freeze happened today. I'll look into the matter once the
ports are unfrozen again, but the change will not make it into 6.2, unless
portmgr@ gives me a permission...
-mi
mi 2007-03-26 08:48:43 UTC
FreeBSD ports repository
Modified files:
audio/festival Makefile distinfo
Added files:
audio/festival/files patch-intptr_t patch-tests
Removed files:
audio/festival/files patch-speech_tools_voxware.cc
Log:
Update to 1.96 (speech_tools 1.2.96) beta. The new version compiles with
gcc-4.2. Add some 64-bitness patches. Enable automatic post-build tests.
Attempt to allow ESound and NAS modules via OPTIONS:
PR: ports/102413
Both are on by default ATM...
Revision Changes Path
1.37 +31 -8 ports/audio/festival/Makefile
1.6 +6 -21 ports/audio/festival/distinfo
1.1 +364 -0 ports/audio/festival/files/patch-intptr_t (new)
1.3 +0 -16 ports/audio/festival/files/patch-speech_tools_voxware.cc (dead)
1.1 +22 -0 ports/audio/festival/files/patch-tests (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Hi, Tom! Please, check, if today's version of the port works for you... Both ESD and NAS are now controlled via OPTIONS (both are on by default). Thanks! Yours, -mi State Changed From-To: open->closed The port was updated 3 weeks ago making ESD and NAS backends controllable via OPTIONS. |
