Summary: | new port: audio/linux-freealut | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jona Joachim <walkingshadow> | ||||
Component: | Individual Port(s) | Assignee: | Boris Samorodov <bsam> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | walkingshadow | ||||
Priority: | Normal | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Jona Joachim
2006-09-04 17:40:18 UTC
Responsible Changed From-To: freebsd-ports-bugs->bsam Take. Hi! Thanks for submitting the port! Here are some comments: - one shouldn't use both PORTVERSION and DISTVERSION at Makefile; - current linux base is linux_base-fc4, but you use an FC3 distribution (consider using LINUX_DIST_VER); - always test your port with devel/portlint utility. You may have a look (for ex.) at audio/linux-alsa-lib. WBR -- bsam State Changed From-To: open->feedback Awating for a feedback. Boris B. Samorodov wrote: > Hi! > > Thanks for submitting the port! > > Here are some comments: > - one shouldn't use both PORTVERSION and DISTVERSION at Makefile; Sorry! diff -Nur linux-freealut_old/Makefile linux-freealut/Makefile --- linux-freealut_old/Makefile Thu Sep 7 14:39:41 2006 +++ linux-freealut/Makefile Thu Sep 7 14:36:56 2006 @@ -6,8 +6,7 @@ # PORTNAME= freealut -PORTVERSION= 1.1.0 -DISTVERSION= ${PORTVERSION}-1.fc${LINUX_DIST_VER} +DISTVERSION= 1.1.0-1.fc${LINUX_DIST_VER} CATEGORIES= audio linux MASTER_SITE_SUBDIR= ../extras/${LINUX_DIST_VER}/${LINUX_RPM_ARCH}/ > - current linux base is linux_base-fc4, but you use an FC3 > distribution (consider using LINUX_DIST_VER); fc4 is hardcoded nowhere, I always use LINUX_DIST_VER, see above. > - always test your port with devel/portlint utility. I always test my ports using portlint. I must have changed the DISTVERSION thing after having tested it. --jona State Changed From-To: feedback->open We had a discussion by email and I've got some patches. State Changed From-To: open->closed Committed, thanks! |