Bug 103161

Summary: Add 'make version' to bsd.port.mk
Product: Ports & Packages Reporter: Lars Engels <lars.engels>
Component: Individual Port(s)Assignee: Port Management Team <portmgr>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
make_version.diff none

Description Lars Engels 2006-09-11 21:50:23 UTC
When run in a port's directory, 'make version' shows the the port's name and version (${PKGNAME}), so no more searching in the Makefile is needed.
While I'm in ports.7, I added the description for 'make maintainer', too.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-09-11 21:50:40 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.port.mk is port manager territory
Comment 2 Kris Kennaway 2006-09-20 05:28:07 UTC
On Mon, Sep 11, 2006 at 10:45:56PM +0200, Lars Engels wrote:

> When run in a port's directory, 'make version' shows the the port's name and version (${PKGNAME}), so no more searching in the Makefile is needed.
> While I'm in ports.7, I added the description for 'make maintainer', too.

What's wrong with 'make -V PKGNAME'?

Kris
Comment 3 Lars Engels 2006-09-20 08:06:32 UTC
Quoting Kris Kennaway <kris@obsecurity.org>:

> On Mon, Sep 11, 2006 at 10:45:56PM +0200, Lars Engels wrote:
>
>> When run in a port's directory, 'make version' shows the the port's  
>>  name and version (${PKGNAME}), so no more searching in the  
>> Makefile  is needed.
>> While I'm in ports.7, I added the description for 'make maintainer', too.
>
> What's wrong with 'make -V PKGNAME'?
>
> Kris

Hi Kris,

in my opinion, 'make -V PKGNAME' is not very user friendly and  
intuitive. And because there is also a 'make maintainer' target, I  
thought it was a good idea to add the 'version' target.
Comment 4 Kirill Ponomarew 2006-09-21 09:51:52 UTC
On Thu, Sep 21, 2006 at 10:43:54AM +0200, Lars Engels wrote:
> Quoting Kirill Ponomarew <krion@voodoo.bawue.com>:
> 
> >If submitter doesn't object, I'd like to close this PR.  We have:
> >
> >.if !target(package-name)
> >package-name:
> >    @${ECHO_CMD} ${PKGNAME}
> >.endif
> >
> >which does exactly what submitter needs.
> >
> >-Kirill
> 
> Oh, sorry, I was not aware of that target.
> 
> What about the 'make maintainer' addition to ports(7)? Is it important  
> enough to add it?

It's worth to add it IMHO.

-Kirill
Comment 5 Kirill Ponomarev freebsd_committer freebsd_triage 2006-11-02 11:13:05 UTC
State Changed
From-To: open->closed

Closed at submitter's request