Summary: | devel/sdl12 fails to compile on 5.5 | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Stefan Walter <sw> |
Component: | Individual Port(s) | Assignee: | Shaun Amott <shaun> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | ||
Priority: | Normal | ||
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any |
Description
Stefan Walter
2006-09-24 13:00:33 UTC
Responsible Changed From-To: freebsd-ports-bugs->shaun Over to maintainer Same problem on HEAD of early august and yesterday build, solved myself but not able to create a patch file because same file (bsd/SDL_sysjoystick.c) is already patched 8-( Hope this help and speed up fix... Quick & Dirty: Start port build, wait for error, edit bsd/SDL_sysjoystick.c, make line 310 the same as 312 and line 449 the same as line 451, continue build, install. More ethical way: diff -u3 SDL_sysjoystick.c.bad SDL_sysjoystick.c --- SDL_sysjoystick.c.bad Thu Sep 28 12:35:57 2006 +++ SDL_sysjoystick.c Thu Sep 28 12:42:29 2006 @@ -307,7 +307,7 @@ } #if defined(USBHID_NEW) || (defined(__FREEBSD__) && __FreeBSD_version >= 500111) - hdata = hid_start_parse(hw->repdesc, 1 << hid_input, rep->rid); + hdata = hid_start_parse(hw->repdesc, 1 << hid_input); #else hdata = hid_start_parse(hw->repdesc, 1 << hid_input); #endif @@ -446,7 +446,7 @@ return; } #if defined(USBHID_NEW) || (defined(__FREEBSD__) && __FreeBSD_version >= 500111) - hdata = hid_start_parse(joy->hwdata->repdesc, 1 << hid_input, rep->rid); + hdata = hid_start_parse(joy->hwdata->repdesc, 1 << hid_input); #else hdata = hid_start_parse(joy->hwdata->repdesc, 1 << hid_input); #endif Clean way (imho): Remove lines 309,310,311,313 and lines 448,449,450,452 (if/else/endif) -- Riccardo. Riccardo Torrini, 28.09.06, 12:52h CEST:
> Same problem on HEAD of early august and yesterday build,
> solved myself but not able to create a patch file because
> same file (bsd/SDL_sysjoystick.c) is already patched 8-(
>
> Hope this help and speed up fix...
Thanks, the proposed changes do indeed make it work on 5.5 as well. I hope
we can get this or an equivalent change in the tree before the ports
freeze.
Regards,
Stefan
State Changed From-To: open->analyzed I am looking into this, but so far I have been unable to reproduce this problem on either -CURRENT or 5.5. I think the problem is bad old header files in your system. I had this problem on one machine: $ ls -l /usr/include/dev/usb/hid.h /usr/include/libusbhid.h /usr/include/libusb.h /usr/include/usbhid.h -r--r--r-- 1 root wheel 3441 2 Feb 2006 /usr/include/dev/usb/hid.h -r--r--r-- 1 root wheel 3457 25 Apr 2001 /usr/include/libusb.h -r--r--r-- 1 root wheel 3500 28 Jan 2005 /usr/include/libusbhid.h -r--r--r-- 1 root wheel 3526 25 Feb 2005 /usr/include/usbhid.h but not on another $ ls -l /usr/include/dev/usb/hid.h /usr/include/libusbhid.h /usr/include/libusb.h /usr/include/usbhid.h ls: /usr/include/libusb.h: No such file or directory ls: /usr/include/libusbhid.h: No such file or directory -r--r--r-- 1 root wheel 3441 Nov 2 2005 /usr/include/dev/usb/hid.h -r--r--r-- 1 root wheel 3526 Nov 2 2005 /usr/include/usbhid.h So, removing /usr/include/libusb.h and /usr/include/libusbhid.h fixes the problem. Regards, Palle Hi,
Palle Girgensohn, 02.10.06, 17:39h CEST:
> I think the problem is bad old header files in your system.
It seems you're right. I found some more old stuff lying around, so I
removed /usr/include completely and did another "make installworld". The
SDL port compiles fine now.
I guess this PR can be closed, then...
Thank you,
Stefan
State Changed From-To: analyzed->closed Identified problem as old header files hanging around. shaun 2006-11-21 16:47:00 UTC FreeBSD ports repository Modified files: devel/sdl12 Makefile Log: - Add an SVGALIB OPTION. [1] - Explicitly disable check for libusbhid.h where appropriate, as some systems still have this header hanging around. [2] PR: ports/104366 [1], ports/103558 (related) [2] Submitted by: Alex Kozlov <spam@rm-rf.kiev.ua> [1], Stefan Walter <sw@gegenunendlich.de> + others [2] Revision Changes Path 1.104 +6 -1 ports/devel/sdl12/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" |