Bug 103868

Summary: [PATCH] audio/xmms2 Makefile (v1.18) breaks "make index"
Product: Ports & Packages Reporter: Richard J. Dawes <rdawes>
Component: Individual Port(s)Assignee: Alexander Botero-Lowry <alexbl>
Status: Closed FIXED    
Severity: Affects Only Me CC: rdawes
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Makefile.diff-against-1.18 none

Description Richard J. Dawes 2006-10-01 14:30:12 UTC 
	The final entry in the OPTIONS line -- intended to be
	commented out -- ends with the '\' line-extender character.
	The effect is that the following .endif is taken as part of
	OPTIONS and not as the .if closer, by "make index" or other
	indexing utilities (e.g. "portsdb -U").

	I say this is "serious" as it breaks the port upgrade workflow
	for everyone, not just audio/xmms2 users.  I suspect there may
	be problems building the port, but I don't use it myself.

	The "make index" error reported follows.  Note that this
	Makefile is seen first via audio/cpp-xmms2/Makefile, where it
	is .include'd ...

"/usr/ports/audio/cpp-xmms2/../xmms2/Makefile", line 221: Unclosed conditional/for loop
"Makefile", line 35: 1 open conditional
make: fatal errors encountered -- cannot continue
===> audio/cpp-xmms2 failed
*** Error code 1
1 error

Fix: Remove the offending '\' character, by editing the Makefile v1.18
 	or by applying the following diff with the 'patch' utility.
How-To-Repeat: 	Run "make index" from the Ports Collection base directory, with
	ports-audio cvsup'ed as recently as Wed Sep 27 15:07:33 2006 UTC
	(timestamp on commit to Makefile v1.18 in CVS).
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-10-01 14:30:27 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->alexbl

Over to maintainer
Comment 2 dfilter service freebsd_committer freebsd_triage 2006-10-01 23:23:20 UTC 
alexbl      2006-10-01 22:23:14 UTC

  FreeBSD ports repository

  Modified files:
    audio/xmms2          Makefile 
  Log:
  - Unbreak INDEX on FreeBSD 4.9
  
  PR:             103868
  Submitted by:   "Richard J. Dawes" <rdawes@epstais.com>
  Approved by:    novel (mentor, implicit)
  
  Revision  Changes    Path
  1.19      +1 -1      ports/audio/xmms2/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Alexander Botero-Lowry freebsd_committer freebsd_triage 2006-10-01 23:23:41 UTC 
State Changed
From-To: open->closed

Committed, thanks!