Bug 104269

Summary: net/samba3 3.0.23c_1,1 pam_winbind.so not load-able by OpenPAM
Product: Ports & Packages Reporter: Dominic Marks <dom>
Component: Individual Port(s)Assignee: Shaun Amott <shaun>
Status: Closed FIXED    
Severity: Affects Only Me CC: timur
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch-za none

Description Dominic Marks 2006-10-10 16:20:22 UTC 
With the latest version of the port pam_winbind.so does not seem to
be load-able by OpenPAM. This causes any system using nsswitch for
authentication to become useless. In my case it caused my workstation
to unusable without a visit to single user mode.

Fix: 

Roll back to 3.0.23b,1.
How-To-Repeat: 1. Install net/samba with pam_winbind.so
2. Modify pam configuration to include it in authentication.
3. Join a AD Domain
4. Try and authenticate
5. Fail

Some example logging information:

gdc083# grep gdm /var/log/messages
Oct 10 14:27:46 gdc083 gdm[61268]: in openpam_load_module(): no /usr/local/lib/pam_winbind.so found
Oct 10 14:27:46 gdc083 gdm[61268]: gdm_verify_check: Can't find PAM configuration for GDM.

gdc083# ls -l /usr/local/lib/pam_winbind.so
-r-xr-xr-x  1 root  wheel  33736 Oct 10 14:15 /usr/local/lib/pam_winbind.so

gdc083# file /usr/local/lib/pam_winbind.so
/usr/local/lib/pam_winbind.so: ELF 32-bit LSB shared object, Intel 80386, version 1 (FreeBSD), stripped
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-10-10 16:21:39 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Shaun Amott freebsd_committer freebsd_triage 2006-10-11 01:27:24 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->shaun

Take it.
Comment 3 Timur I. Bakeyev 2006-10-11 02:47:38 UTC 
Hi, Dominic!

Thank you for your report! I did some tests and found out that the problem
is caused by usage of strequal() function in the code? which isn't linked 
into the pam_winbind.so. The easiest solution is to replace it with strcmp().

I do attach the patch to this mail that have to replace original one in the
port. You can just place in into files/ instead of original one.

With best regards,
Timur.
Comment 4 Dominic Marks 2006-10-11 10:36:28 UTC 
On Wed, 11 Oct 2006 03:47:38 +0200
"Timur I. Bakeyev" <timur@gnu.org> wrote:

> Hi, Dominic!
> 
> Thank you for your report! I did some tests and found out that the problem
> is caused by usage of strequal() function in the code? which isn't linked 
> into the pam_winbind.so. The easiest solution is to replace it with strcmp().
> 
> I do attach the patch to this mail that have to replace original one in the
> port. You can just place in into files/ instead of original one.

Thanks. I assume this will be committed soon?
Thanks you very much Timur, very quick fix. Excellent work!

Dominic

> With best regards,
> Timur.
Comment 5 Timur I. Bakeyev 2006-10-11 12:26:00 UTC 
Hi Dominic!

On Wed, Oct 11, 2006 at 10:36:28AM +0100, Dominic Marks wrote:
> 
> Thanks. I assume this will be committed soon?
> Thanks you very much Timur, very quick fix. Excellent work!

There is a slight problem with commitment - ports tree is frozen for
upcoming 6.2 release, so if this fix won't be approved by portmanager,
you have to wait a week or so.

So, if you want immediate results - try the attached patch now :)

With best regards,
Timur.
Comment 6 Shaun Amott freebsd_committer freebsd_triage 2006-10-11 20:59:13 UTC 
State Changed
From-To: feedback->closed

Fix provided by maintainer was committed.
Comment 7 dfilter service freebsd_committer freebsd_triage 2006-10-11 21:42:28 UTC 
shaun       2006-10-11 20:40:35 UTC

  FreeBSD ports repository

  Modified files:
    net/samba3           Makefile 
    net/samba3/files     patch-za 
  Log:
  Fix a bug introduced by a previous patch, whereby pam_winbind.so would
  fail to load correctly.
  
  PR:             ports/104269
  Submitted by:   Dominic Marks <dom@helenmarks.co.uk>
  Approved by:    portmgr (erwin)
  
  Revision  Changes    Path
  1.155     +1 -1      ports/net/samba3/Makefile
  1.2       +1 -1      ports/net/samba3/files/patch-za
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"