Bug 104686

Summary: unbreak installation of mail/majordomo
Product: Ports & Packages Reporter: Kay Abendroth <kay.abendroth>
Component: Individual Port(s)Assignee: Anders Nordby <anders>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Kay Abendroth 2006-10-22 22:10:15 UTC
Previously removed files from mail/majordomo weren't removed from Makefile.

Fix: Apply the following patch.

Patch attached with submission follows:
How-To-Repeat: Install a mail/majordomo
Comment 1 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-10-22 22:16:09 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-ports-bugs

Fix Category and resposible
Comment 2 ru freebsd_committer freebsd_triage 2006-10-23 09:26:48 UTC
Responsible Changed
From-To: freebsd-ports-bugs->erwin

Erwin, you broke it: 

: RCS file: /home/ncvs/ports/mail/majordomo/files/Attic/test-l-digest,v 
: ---------------------------- 
: revision 1.4 
: date: 2006/07/10 20:44:47;  author: erwin;  state: dead;  lines: +0 -0 
: Remove zero-sized files. 
: ============================================================================= 

: RCS file: /home/ncvs/ports/mail/majordomo/files/Attic/test-l,v 
: ---------------------------- 
: revision 1.4 
: date: 2006/07/10 20:44:47;  author: erwin;  state: dead;  lines: +0 -0 
: Remove zero-sized files.
Comment 3 Erwin Lansing freebsd_committer freebsd_triage 2006-11-15 21:49:47 UTC
Responsible Changed
From-To: erwin->anders

Over to maintainer with following patch that fixes the 
problems introduced by my removal of those empty files 
from cvs and also makes it possible to be tested on 
tinderbox/pointyhat, which turned up some more issues 
that are fixed. 

Removed file: 
scripts/createuser 
Added files: 
pkg-install 
pkg-deinstall 

http://people.freebsd.org/~erwin/majordomo.diff 

- Fix the installation of two empty files by touching them 
instead of installing empty files from cvs 
- Make non-interactive by bringing the user/group creating 
in line with best practice instead of home-rolled script 
- Fix pkg-plist by comparing the aliases.majordomo file 
to a sample file. 
- Portlint 
- Bump PORTREVISION
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-02-19 00:13:40 UTC
anders      2007-02-19 00:13:35 UTC

  FreeBSD ports repository

  Modified files:
    mail/majordomo       Makefile 
  Log:
  Unbreak installation.
  
  PR:             104686
  
  Revision  Changes    Path
  1.38      +4 -1      ports/mail/majordomo/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Anders Nordby freebsd_committer freebsd_triage 2007-02-19 00:15:04 UTC
I've committed a fix. Erwin's patch is now unfortunately missing?

-- 
Anders.
Comment 6 Erwin Lansing freebsd_committer freebsd_triage 2007-02-19 07:54:35 UTC
On Mon, Feb 19, 2007 at 01:15:04AM +0100, Anders Nordby wrote:
> I've committed a fix. Erwin's patch is now unfortunately missing?
> 

That is not a fix, but a very ugly hack, just like the rest of this
port.  Unfortunately, you've ignored this for so many months that I
accidentily deleted the patch from freefall, but you could have asked
for it before committing this.  The patch is on freefall again.

-erwin

-- 
Erwin Lansing                                     http://droso.org
Security is like an onion.          (o_ _o)
It's made up of several layers   \\\_\   /_///
And it makes you cry.            <____) (____>    erwin@lansing.dk
Comment 7 Anders Nordby freebsd_committer freebsd_triage 2007-02-19 09:27:08 UTC
Hi,

On Mon, Feb 19, 2007 at 08:54:35AM +0100, Erwin Lansing wrote:
>> I've committed a fix. Erwin's patch is now unfortunately missing?
> That is not a fix, but a very ugly hack, just like the rest of this
> port.  Unfortunately, you've ignored this for so many months that I
> accidentily deleted the patch from freefall, but you could have asked
> for it before committing this.  The patch is on freefall again.

I think most people prefer an installable port. Do you actually use
majordomo? I do, and yesterday I could not install it without modifying
Makefile, due to you deleting test-l and test-l-digest.

I didn't ignore your patch, I've just been busy with other things. I
will look into it as soon as time permits. Thanks anyway, for the patch.

I agree that this port could have been much better. Then again,
majordomo is a stale project with not much happening. The last version
(1.94.5) was released in january 2000. I wouldn't recommend new
installations of majordomo now at all, but I suppose there are still
many people using it. Maybe we should put a warning in the port, asking
the user if he/she really wants to install. Hmm.

Regards,

-- 
Anders.
Comment 8 dfilter service freebsd_committer freebsd_triage 2007-03-01 20:56:53 UTC
anders      2007-03-01 20:56:42 UTC

  FreeBSD ports repository

  Modified files:
    mail/majordomo       Makefile pkg-plist 
    mail/majordomo/files post-install-notes 
    mail/majordomo/scripts adaptwrapper 
  Added files:
    mail/majordomo       pkg-deinstall pkg-install 
  Removed files:
    mail/majordomo/scripts createuser 
  Log:
  Make port build, install and run as package.
  Give warning upon installing, majordomo is legacy.
  
  PR:             104686
  Submitted by:   erwin, anders
  
  Revision  Changes    Path
  1.39      +38 -48    ports/mail/majordomo/Makefile
  1.9       +16 -9     ports/mail/majordomo/files/post-install-notes
  1.1       +17 -0     ports/mail/majordomo/pkg-deinstall (new)
  1.1       +48 -0     ports/mail/majordomo/pkg-install (new)
  1.8       +2 -1      ports/mail/majordomo/pkg-plist
  1.2       +9 -1      ports/mail/majordomo/scripts/adaptwrapper
  1.6       +0 -61     ports/mail/majordomo/scripts/createuser (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Anders Nordby freebsd_committer freebsd_triage 2007-03-01 20:56:54 UTC
State Changed
From-To: open->closed

Update committed, with a number of modifications however, making the port 
work as a package.