Bug 104837

Summary: [PATCH] deskutils/knowit: fix pkg-plist, pet porlint
Product: Ports & Packages Reporter: Thomas Abthorpe <thomas>
Component: Individual Port(s)Assignee: Alejandro Pulver <alepulver>
Status: Closed FIXED    
Severity: Affects Only Me CC: thomas
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
knowit-0.10_3.patch none

Description Thomas Abthorpe 2006-10-26 20:00:35 UTC
- fix pkg-plist, adresses http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/e.7.2006101922/knowit-0.10_3.log
- use INSTALLS_ICONS to pet portlint.

Generated with FreeBSD Port Tools 0.77
Comment 1 Alejandro Pulver freebsd_committer freebsd_triage 2006-10-31 23:05:58 UTC
Responsible Changed
From-To: freebsd-ports-bugs->alepulver

I'll take it.
Comment 2 thomasa 2006-11-04 05:14:06 UTC
Please accept the following patch amendments

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/deskutils/knowit/Makefile,v
retrieving revision 1.18
diff -u -r1.18 Makefile
--- Makefile    15 Aug 2006 08:27:46 -0000      1.18
+++ Makefile    4 Nov 2006 05:12:51 -0000
@@ -21,12 +21,15 @@
 USE_KDELIBS_VER=       3
 USE_GMAKE=     yes
 USE_AUTOTOOLS= libtool:15
+INSTALLS_ICONS=        yes
 MAKE_ARGS=     ACLOCAL="${TRUE}" AUTOCONF="${TRUE}" AUTOHEADER="${TRUE}" \
                AUTOMAKE="${TRUE}"

 QTCPPFLAGS+=   ${PTHREAD_CFLAGS}
 QTCFGLIBS+=    ${PTHREAD_LIBS}

+DOCSDIR=share/doc/HTML
+
 post-patch:
        @${REINPLACE_CMD} -e 's|-O2||g ; \
                 s|-lpthread|${PTHREAD_LIBS}|g' ${WRKSRC}/configure


Index: pkg-plist
===================================================================
RCS file: /home/ncvs/ports/deskutils/knowit/pkg-plist,v
retrieving revision 1.9
diff -u -r1.9 pkg-plist
--- pkg-plist   15 Aug 2006 07:56:18 -0000      1.9
+++ pkg-plist   4 Nov 2006 05:14:06 -0000
@@ -2,10 +2,10 @@
 share/applnk/Applications/knowit.desktop
 share/apps/knowit/knowitui.rc
 share/apps/knowit/tips
-share/doc/HTML/en/knowit/common
-share/doc/HTML/en/knowit/index.cache.bz2
-share/doc/HTML/en/knowit/index.docbook
-share/doc/HTML/en/knowit/screenshot.png
+%%DOCSDIR%%/en/knowit/common
+%%DOCSDIR%%/en/knowit/index.cache.bz2
+%%DOCSDIR%%/en/knowit/index.docbook
+%%DOCSDIR%%/en/knowit/screenshot.png
 share/icons/hicolor/16x16/apps/knowit.png
 share/icons/hicolor/32x32/apps/knowit.png
 share/locale/de/LC_MESSAGES/knowit.mo
@@ -18,15 +18,9 @@
 share/locale/zh_CN.GB2312/LC_MESSAGES/knowit.mo
 @dirrmtry share/mimelnk/application
 @dirrmtry share/mimelnk
-@dirrmtry share/icons/hicolor/32x32/apps
-@dirrmtry share/icons/hicolor/32x32
-@dirrmtry share/icons/hicolor/16x16/apps
-@dirrmtry share/icons/hicolor/16x16
-@dirrmtry share/icons/hicolor
-@dirrmtry share/icons
-@dirrm share/doc/HTML/en/knowit
-@dirrmtry share/doc/HTML/en
-@dirrmtry share/doc/HTML
+@dirrm %%DOCSDIR%%/en/knowit
+@dirrmtry %%DOCSDIR%%/en
+@dirrmtry %%DOCSDIR%%
 @dirrm share/apps/knowit
 @dirrmtry share/applnk/Applications
 @dirrmtry share/applnk
Comment 3 Alejandro Pulver freebsd_committer freebsd_triage 2006-11-06 17:20:25 UTC
State Changed
From-To: open->closed

Committed. Thanks!