Bug 104845
| Summary: | [patch] Build error on contrib/file/magic(5) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Ryoji Kanai <kanai> | ||||
| Component: | bin | Assignee: | Antoine Brodin <antoine> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | Unspecified | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Ryoji Kanai
2006-10-27 03:00:35 UTC
On Fri, Oct 27, 2006 at 01:51:22AM +0000, Ryoji Kanai wrote: > That's it. You should get a Segmentation fault. Is this only me? Maybe. There was a segfault fix to this file 4 months ago, can you please confirm that you have it? > >Fix: > I GDBed the magic program and found this. I'm not sure this is the right way to fix it. You could also check with the authors. Kris At Fri, 27 Oct 2006 00:38:42 -0400, Kris Kennaway wrote: > > That's it. You should get a Segmentation fault. Is this only me? > > Maybe. There was a segfault fix to this file 4 months ago, can you > please confirm that you have it? My fix is another problem. The problem exists even in the latest code. > > >Fix: > > I GDBed the magic program and found this. I'm not sure this is the right way to fix it. > > You could also check with the authors. I talked with Christos Zoulas (maintainer). He said this was a bug and he fixed it. I hope new version will be released soon. Anyway, you can close this pr and set a "should update contrib/file to the next version" flag. Thanks! On Fri, Oct 27, 2006 at 12:58:45PM -0700, Ryoji Kanai wrote:
>
> At Fri, 27 Oct 2006 00:38:42 -0400,
> Kris Kennaway wrote:
>
> > > That's it. You should get a Segmentation fault. Is this only me?
> >
> > Maybe. There was a segfault fix to this file 4 months ago, can you
> > please confirm that you have it?
>
> My fix is another problem. The problem exists even in the latest code.
>
> > > >Fix:
> > > I GDBed the magic program and found this. I'm not sure this is the right way to fix it.
> >
> > You could also check with the authors.
>
> I talked with Christos Zoulas (maintainer). He said this was a bug
> and he fixed it. I hope new version will be released soon. Anyway, you
> can close this pr and set a "should update contrib/file to the next
> version" flag.
Interesting, I wonder why others aren't seeing it. Do you have
nonstandard MALLOC_OPTIONS (or /etc/malloc.conf)?
If Christos has imported the fix, we can also do a vendor import of
just your patch into FreeBSD since it won't cause a divergence from
vendor code.
Kris
> Interesting, I wonder why others aren't seeing it. Do you have > nonstandard MALLOC_OPTIONS (or /etc/malloc.conf)? Yeah, it's wired. I don't have malloc.conf and any MALLOC* options. But, check the code. This is a bug. > If Christos has imported the fix, we can also do a vendor import of > just your patch into FreeBSD since it won't cause a divergence from > vendor code. I think he has imported. I sent the same patch that I sent with this pr. And, he simply said At Fri, 27 Oct 2006 10:57:58 -0400, Christos Zoulas wrote: > You are absolutely right; I just fixed it. > > Thanks, > > christos If you can import my patch, that would be great. -- Ryoji State Changed From-To: open->feedback Dear submitter, file version 4.23 has been imported in freebsd and merged to RELENG_7 and RELENG_6. Can you confirm it fixes your problem? Thanks. Responsible Changed From-To: freebsd-bugs->antoine Track. State Changed From-To: feedback->closed Close: I believe this is fixed + feedback timeout (1 month). |
