Bug 104919

Summary: [patch] fix sysutils/cronolog
Product: Ports & Packages Reporter: David Wood <david>
Component: Individual Port(s)Assignee: Shaun Amott <shaun>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description David Wood 2006-10-30 01:50:18 UTC 
http://cronolog.org/patches/cronolog-missing-symlink-patch.txt describes a fix for cronolog when the destination of a symlink that cronolog is attempting to update no longer exists. On my machine this happens because cron comes along and gzips the logs.

Fix: The following turns the patch described in http://cronolog.org/patches/cronolog-missing-symlink-patch.txt into a unified diff and applies it before the (optional) setuid/setgid patch.

Attempting to apply this patch after the setuid/setgid patch (for example, by calling the file files/patch...) fails, as the line numbers in cronoutils.c have been changed by the setuid/setgid patch.

Note the new file - files/cronolog-missing_symlink_bug-patch

--- Patch begins ---
How-To-Repeat: Delete or rename a file that cronolog has symlinked to when using the --symlink= option. The symlink won't be updated in the future.
Comment 1 David Wood 2006-10-30 02:33:22 UTC 
Bother - this should have been

Category: ports
Responsible: shaun@freebsd.org (maintainer)

I suck at submitting problem reports - sorry. Can someone fix this?
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2006-10-30 03:46:24 UTC 
Responsible Changed
From-To: freebsd-bugs->shaun

Over to maintainer.
Comment 3 Shaun Amott freebsd_committer freebsd_triage 2006-12-11 00:34:28 UTC 
State Changed
From-To: open->closed

Committed, thanks! 

BTW: you don't need to worry about the assignment/state fields in GNATS; 
they are handled automatically.
Comment 4 dfilter service freebsd_committer freebsd_triage 2006-12-11 01:02:13 UTC 
shaun       2006-12-11 01:00:20 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/cronolog    Makefile 
  Added files:
    sysutils/cronolog/files extrapatch-src_cronoutils.c 
  Log:
  Fix bug in symlinked log file handling.
  
  PR:             ports/104919
  Submitted by:   David Wood <david@wood2.org.uk>
  Obtained from:  http://cronolog.org/patches/cronolog-missing-symlink-patch.txt
  
  Revision  Changes    Path
  1.16      +7 -5      ports/sysutils/cronolog/Makefile
  1.1       +11 -0     ports/sysutils/cronolog/files/extrapatch-src_cronoutils.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"