Bug 105026

Summary: [PATCH] Missing space between skip site and section navigation
Product: Documentation Reporter: Rudolf Čejka <cejkar>
Component: Books & ArticlesAssignee: Gabor Kovesdan <gabor>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Rudolf Čejka 2006-11-01 16:30:21 UTC 
This problem is very similar to the PR www/104925, however I think that
I have found simple and elegant solution here.

Just take a look at both http://www.FreeBSD.org/ (xsl page) and
http://www.FreeBSD.org/where.html (sgml page) in txtoffscreen mode
(basic page style in Mozilla) and compare them. There is a space
between Skip site navigation (1) and Skip section navigation (2), but
just in case of sgml sourced page. Page generated from xsl is
missing it.

I think that I have found a solution here - the patch below simply
joins two <span>...</span> blocks into one, where white space removal
does not occur in sgml nor in xsl case.

--- www/share/sgml/header.ent.orig	Wed Nov  1 17:09:57 2006
+++ www/share/sgml/header.ent	Wed Nov  1 17:10:43 2006
@@ -123,9 +123,8 @@
 <!ENTITY header2 '
 <span class="txtoffscreen"
 ><a href="#CONTENT" title="Skip site navigation" accesskey="1"
->Skip site navigation</a> (1)</span>
-<span class="txtoffscreen"
-><a href="#CONTENTWRAP" title="Skip section navigation" accesskey="2"
+>Skip site navigation</a> (1)
+<a href="#CONTENTWRAP" title="Skip section navigation" accesskey="2"
 >Skip section navigation</a> (2)</span>
Comment 1 Ceri Davies 2006-11-02 17:34:34 UTC 
On Wed, Nov 01, 2006 at 05:28:08PM +0100, Rudolf Cejka wrote:

> I think that I have found a solution here - the patch below simply
> joins two <span>...</span> blocks into one, where white space removal
> does not occur in sgml nor in xsl case.

It's wrong though; they are separate span's and should be marked up as
such.

Ceri
-- 
That must be wonderful!  I don't understand it at all.
                                                  -- Moliere
Comment 2 Rudolf Čejka 2006-11-03 08:01:11 UTC 
Ceri Davies wrote (2006/11/02):
> > I think that I have found a solution here - the patch below simply
> > joins two <span>...</span> blocks into one, where white space removal
> > does not occur in sgml nor in xsl case.
> It's wrong though; they are separate span's and should be marked up as
> such.

Why? I think that <span class="txtoffscreen">...</span> just wants to
say, when to display the text included. And if there should be skipped
or included two adjacent texts, why the space between then should be
displayed in all cases? (The space is then removed probably too, but
I wanted to express logical explanation here, why I do not understand,
why there should be two spans and not just one.)

-- 
Rudolf Cejka <cejkar at fit.vutbr.cz> http://www.fit.vutbr.cz/~cejkar
Brno University of Technology, Faculty of Information Technology
Bozetechova 2, 612 66  Brno, Czech Republic
Comment 3 Ceri Davies 2006-11-04 10:25:09 UTC 
On Fri, Nov 03, 2006 at 09:01:11AM +0100, Rudolf Cejka wrote:
> Ceri Davies wrote (2006/11/02):
> > > I think that I have found a solution here - the patch below simply
> > > joins two <span>...</span> blocks into one, where white space removal
> > > does not occur in sgml nor in xsl case.
> > It's wrong though; they are separate span's and should be marked up as
> > such.
> 
> Why? I think that <span class="txtoffscreen">...</span> just wants to
> say, when to display the text included. And if there should be skipped
> or included two adjacent texts, why the space between then should be
> displayed in all cases? (The space is then removed probably too, but
> I wanted to express logical explanation here, why I do not understand,
> why there should be two spans and not just one.)

Yeah, you're probably right.

Ceri
-- 
That must be wonderful!  I don't understand it at all.
                                                  -- Moliere
Comment 4 Gabor Kovesdan freebsd_committer freebsd_triage 2007-02-06 10:14:44 UTC 
Responsible Changed
From-To: freebsd-www->gabor

Take.
Comment 5 dfilter service freebsd_committer freebsd_triage 2007-02-15 21:49:53 UTC 
gabor       2007-02-15 21:49:46 UTC

  FreeBSD doc repository

  Modified files:
    share/sgml           header.ent 
  Log:
  - Use single <span> for "Skip site navigation" and
    "Skip section navigation" and thus add the missing space between them
  
  PR:             www/105026
  Submitted by:   Rudolf Cejka <cejkar@fit.vutbr.cz>
  Approved by:    keramida (mentor)
  
  Revision  Changes    Path
  1.6       +3 -4      www/share/sgml/header.ent
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Gabor Kovesdan freebsd_committer freebsd_triage 2007-02-15 21:52:44 UTC 
State Changed
From-To: open->closed

Committed, thanks!