Bug 105220

Summary: maintainer update: audio/kid3
Product: Ports & Packages Reporter: Max Brazhnikov <makc>
Component: Individual Port(s)Assignee: Tilman Keskinoz <arved>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
kid3.diff none

Description Max Brazhnikov 2006-11-06 19:20:18 UTC 
include upstream patches:
- allow building with tunepimp 0.5.x
- fix inadvertent changes of ID3v2.3 genre strings
- import from freedb2.org

Fix: Patch attached with submission follows:
Comment 1 ru freebsd_committer freebsd_triage 2006-11-06 19:34:54 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-ports

Misfiled PR.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2006-11-06 19:49:36 UTC 
Responsible Changed
From-To: freebsd-ports->freebsd-ports-bugs

Canonicalize assignment.
Comment 3 Tilman Keskinoz freebsd_committer freebsd_triage 2006-11-07 17:25:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->	 arved

Take. 

The patch files to Makefile.in's seem uneccessary.  
Did you try shortening the patch-configure by patching configure.in?
Comment 4 dfilter service freebsd_committer freebsd_triage 2006-11-19 16:13:40 UTC 
arved       2006-11-19 16:13:33 UTC

  FreeBSD ports repository

  Modified files:
    audio/kid3           Makefile 
  Added files:
    audio/kid3/files     patch-configure 
                         patch-kid3__freedbclient.cpp 
                         patch-kid3__freedbclient.h 
                         patch-kid3__freedbdialog.cpp 
                         patch-kid3__freedbdialog.h 
                         patch-kid3__genres.cpp 
                         patch-kid3__genres.h 
                         patch-kid3__id3form.cpp 
                         patch-kid3__mp3file.cpp 
                         patch-kid3__musicbrainzclient.cpp 
                         patch-kid3__musicbrainzclient.h 
                         patch-kid3__oggfile.cpp 
  Removed files:
    audio/kid3/files     patch-kid3-oggfile.cpp 
  Log:
  Add upstream patches:
  - Build with tunepimp 0.5.x
  - fix inadvertent changes of ID3v2.3 genre strings
  - import from freedb2.org
  Bump PORTREVISION.
  
  PR:             105220
  Submitted by:   Max Brazhnikov
  
  Revision  Changes    Path
  1.4       +2 -10     ports/audio/kid3/Makefile
  1.1       +232 -0    ports/audio/kid3/files/patch-configure (new)
  1.2       +0 -11     ports/audio/kid3/files/patch-kid3-oggfile.cpp (dead)
  1.1       +101 -0    ports/audio/kid3/files/patch-kid3__freedbclient.cpp (new)
  1.1       +44 -0     ports/audio/kid3/files/patch-kid3__freedbclient.h (new)
  1.1       +96 -0     ports/audio/kid3/files/patch-kid3__freedbdialog.cpp (new)
  1.1       +15 -0     ports/audio/kid3/files/patch-kid3__freedbdialog.h (new)
  1.1       +11 -0     ports/audio/kid3/files/patch-kid3__genres.cpp (new)
  1.1       +11 -0     ports/audio/kid3/files/patch-kid3__genres.h (new)
  1.1       +11 -0     ports/audio/kid3/files/patch-kid3__id3form.cpp (new)
  1.1       +14 -0     ports/audio/kid3/files/patch-kid3__mp3file.cpp (new)
  1.1       +356 -0    ports/audio/kid3/files/patch-kid3__musicbrainzclient.cpp (new)
  1.1       +146 -0    ports/audio/kid3/files/patch-kid3__musicbrainzclient.h (new)
  1.1       +11 -0     ports/audio/kid3/files/patch-kid3__oggfile.cpp (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Tilman Keskinoz freebsd_committer freebsd_triage 2006-11-19 16:14:38 UTC 
State Changed
From-To: open->closed

Committed with some changes. Please review. 
Thanks!
Comment 6 Max Brazhnikov 2006-11-20 07:39:55 UTC 
I've removed needless patches and rewrote Makefile.
diff is attached.