Bug 105436

Summary:	graphics/libgphoto2: closes wrong dbus connection, leads to applications crashing
Product:	Ports & Packages	Reporter:	Christoph Moench-Tegeder <cmt>
Component:	Individual Port(s)	Assignee:	Pav Lucistnik <pav>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Latest
Hardware:	Any
OS:	Any

Description Christoph Moench-Tegeder freebsd_committer

2006-11-12 12:50:20 UTC

	libgphoto2 should not close the dbus connection in
	libgphoto2_port/disk/disk.c as this connection is a shared connection.
	Closing a shared connection causes an error from dbus, wich in turn
	leads to crashing applications (her: f-spot).
	See also: http://gphoto.svn.sourceforge.net/viewvc/gphoto/trunk/libgphoto2/libgphoto2_port/disk/disk.c?view=log#rev9150

Fix: 

Upstream should release a new version of libgphoto2. For the time
	being, use the patch below:

	--- libgphoto2_port/disk/disk.c.orig    Sun Nov 12 13:17:21 2006
	+++ libgphoto2_port/disk/disk.c Sun Nov 12 13:17:59 2006
	@@ -175,7 +175,6 @@
 	
        	libhal_free_string_array (volumes);
        	libhal_ctx_free (ctx);
	-       dbus_connection_disconnect (dbus_connection);
        	dbus_connection_unref (dbus_connection);
 	#else
 	# ifdef HAVE_MNTENT_H
How-To-Repeat: 	Start f-spot, go to File->Import and watch the error message.

Comment 1 Edwin Groothuis freebsd_committer

2006-11-12 12:50:31 UTC

Responsible Changed
From-To: freebsd-ports-bugs->pav

Over to maintainer

Comment 2 Pav Lucistnik freebsd_committer

2006-11-12 13:36:43 UTC

State Changed
From-To: open->closed

Patch added to the port.

Comment 3 dfilter service freebsd_committer

2006-11-12 13:37:29 UTC

pav         2006-11-12 13:37:23 UTC

  FreeBSD ports repository

  Modified files:
    graphics/libgphoto2  Makefile 
  Added files:
    graphics/libgphoto2/files patch-libgphoto2_port-disk-disk.c 
  Log:
  - Add a patch to not close shared dbus connections
  
  PR:             ports/105436
  Submitted by:   Christoph Moench-Tegeder <cmt@burggraben.net>
  Obtained from:  gphoto svn
  
  Revision  Changes    Path
  1.29      +1 -1      ports/graphics/libgphoto2/Makefile
  1.1       +10 -0     ports/graphics/libgphoto2/files/patch-libgphoto2_port-disk-disk.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"