Bug 106104
| Summary: | [PATCH] Turn on inverted external amplifier sense flags for HP Compaq nx 4300 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Shun-ichi Kobayashi <koba> | ||||
| Component: | kern | Assignee: | Ariff Abdullah <ariff> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | 6.2-PRERELEASE | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
>Number: 106104 >Category: kern >Synopsis: [PATCH] Turn on inverted external amplifier sense flags for HP Compaq nx 4300 >Severity: serious >Priority: medium >Responsible: freebsd-bugs@FreeBSD.org >State: open >Class: sw-bug >Arrival-Date: Fri Dec 01 01:50:14 GMT 2006 >Closed-Date: >Last-Modified: never >Originator: Shun-ichi Kobayashi >Release: FreeBSD 6.2-PRERELEASE i386 >Description: It is already known that some machines that uses ich(4) sound driver must turn on inverted external amplifier sense flag individually. See: Rev. 1.57 and Rev. 1.58 (I also referred an email entitled "kern/94056:[PATCH] ..." in freebsd-bugs ML) My machine HP Compaq nx 4300 also requires this. [machine] HP Compaq nx 4300 [pciconf -vl] pcm0@pci0:30:2: class=0x040100 card=0x309a103c chip=0x266e8086 rev=0x04 hdr=0x00 vendor = 'Intel Corporation' device = '82801FB/FR/FW/FRW AC '97 Audio Controller' class = multimedia subclass = audio >How-To-Repeat: >Fix: I attached a simple patch file for this bug to this email. Original file is /usr/src/sys/dev/sound/pci/ich.c,v 1.53.2.8 2006/08/22 02:37:03 Attached patch file is named as ich.c.diff (created by diff -c) Here is a copied and pasted version for your reference. *** /usr/src/sys/dev/sound/pci/ich.c.orig Tue Nov 28 18:48:52 2006 --- /usr/src/sys/dev/sound/pci/ich.c Fri Dec 1 10:41:07 2006 *************** *** 851,856 **** --- 851,857 ---- case 0x81c0104d: /* Sony VAIO type T */ case 0x81c5104d: /* Sony VAIO VGN B1VP/B1XP */ case 0x3089103c: /* Compaq Presario B3800 */ + case 0x309a103c: /* HP Compaq nx4300 */ ac97_setflags(sc->codec, ac97_getflags(sc->codec) | AC97_F_EAPD_INV); break; default: Responsible Changed From-To: freebsd-bugs->ariff I'll handle this. ariff 2006-12-01 06:53:14 UTC
FreeBSD src repository
Modified files:
sys/dev/sound/pci ich.c
Log:
Add inverted amplifier sense quirk for HP Compaq nx4300.
PR: kern/106104
Submitted by: Shun-ichi Kobayashi <koba@mbox.kudpc.kyoto-u.ac.jp>
MFC after: 3 days
Revision Changes Path
1.69 +1 -0 src/sys/dev/sound/pci/ich.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->patched Committed to HEAD. ariff 2006-12-24 05:44:11 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_6)
sys/dev/sound/pci ich.c
Log:
MFC:
Add inverted amplifier sense quirk for HP Compaq nx4300 and few
NEC VersaPro.
PR: kern/106104, kern/104715
Submitted by: Shun-ichi Kobayashi <koba@mbox.kudpc.kyoto-u.ac.jp>
KAWATA Masahiko <kawata@mta.biglobe.ne.jp>
Add support for Nvidia Nforce MCP04 AC97 controller.
PR: kern/106829
Submitted by: Frédéric Petit <fredantispam@free.fr>
Revision Changes Path
1.53.2.9 +6 -0 src/sys/dev/sound/pci/ich.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
ariff 2006-12-24 05:44:47 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_6_2)
sys/dev/sound/pci ich.c
Log:
MFC:
Add inverted amplifier sense quirk for HP Compaq nx4300 and few
NEC VersaPro.
PR: kern/106104, kern/104715
Submitted by: Shun-ichi Kobayashi <koba@mbox.kudpc.kyoto-u.ac.jp>
KAWATA Masahiko <kawata@mta.biglobe.ne.jp>
Add support for Nvidia Nforce MCP04 AC97 controller.
PR: kern/106829
Submitted by: Frédéric Petit <fredantispam@free.fr>
Approved by: re (kensmith)
Revision Changes Path
1.53.2.8.2.1 +6 -0 src/sys/dev/sound/pci/ich.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: patched->closed Fix committed to both RELENG_6 and 6_2. |
It is already known that some machines that uses ich(4) sound driver must turn on inverted external amplifier sense flag individually. See: Rev. 1.57 and Rev. 1.58 (I also referred an email entitled "kern/94056:[PATCH] ..." in freebsd-bugs ML) My machine HP Compaq nx 4300 also requires this. [machine] HP Compaq nx 4300 [pciconf -vl] pcm0@pci0:30:2: class=0x040100 card=0x309a103c chip=0x266e8086 rev=0x04 hdr=0x00 vendor = 'Intel Corporation' device = '82801FB/FR/FW/FRW AC '97 Audio Controller' class = multimedia subclass = audio Fix: I made a simple patch for this bug. I will follow up via email.