Bug 107125

Summary: [PATCH] emulators/zsnes: update to 1.50
Product: Ports & Packages Reporter: Naram Qashat <cyberbotx>
Component: Individual Port(s)Assignee: Jose Alonso Cardenas Marquez <acm>
Status: Closed FIXED    
Severity: Affects Only Me CC: freebsd-ports
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
zsnes-1.50,1.patch none

Description Naram Qashat 2006-12-23 02:10:09 UTC 
- Update to 1.50
  - Added a few new OPTIONS knobs
  - Distfile is now a .tar.bz2 instead of a .tar.gz
  - Target ALL wasn't valid
  - Removed substitutions to configure because they were unnessacary
  - Added in check to look for zlib 1.2.3 or greater, now required by ZSNES
  - Patch to linux/zfilew.c no longer needed

Removed file(s):
- files/patch-linux-zfilew.c

Port maintainer (freebsd-ports@stsp.in-berlin.de) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-12-23 02:10:21 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 freebsd-ports 2006-12-23 02:48:23 UTC 
> +pre-everything::
> +	@${GREP} "#define ZLIB_VERSION" /usr/include/zlib.h | \
> +		${AWK} '{print substr($$3, 2, length($$3) - 2)}' | \
> +		${SED} 's/\./ /g' | \
> +		${AWK} '{printf("%02d%02d%02d", $$1, $$2, $$3)}' | \
> +		${AWK} '{if ($$1 > 010202) {exit 0} else {exit 1}}'
> +	@if [ 0 -ne $$? ] ; then \
> +		@${ECHO} "This port requires zlib >= 1.2.3" ; \
> +		@${FALSE} ; \
> +	fi


The pre-everything target causes the following here:

	[stsp@ted /usr/ports/emulators/zsnes]$ make
	*** Error code 1

	Stop in /usr/ports/emulators/zsnes.

It gives users no clue as to what is going on unless they
look into the Makefile.

When I change it to:

pre-everything::
	@${GREP} "#define ZLIB_VERSION" /usr/include/zlib.h | \
		${AWK} '{print substr($$3, 2, length($$3) - 2)}' | \
		${SED} 's/\./ /g' | \
		${AWK} '{printf("%02d%02d%02d", $$1, $$2, $$3)}' | \
		${AWK} '{if ($$1 > 010202) {exit 0} else {exit 1}}' \
		|| (${ECHO} "This port requires zlib >= 1.2.3"; ${FALSE};)

it prints the message correctly:

	[stsp@ted /usr/ports/emulators/zsnes]$ make
	This port requires zlib >= 1.2.3
	*** Error code 1

	Stop in /usr/ports/emulators/zsnes.

I have a 6.1 system only. According to CVS log, zlib-1.2.3 is in 6.2.
I cannot test this properly until I've upgraded to 6.2.

Apart from the small error in the pre-everything target described
above, the patch looks very good.

-- 
stefan
http://stsp.in-berlin.de                                 PGP Key: 0xF59D25F0
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2006-12-23 10:18:00 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 4 Martin Wilke freebsd_committer freebsd_triage 2007-01-16 20:35:49 UTC 
Responsible Changed
From-To: miwi->acm

acm@ handel this :). Thanks
Comment 5 dfilter service freebsd_committer freebsd_triage 2007-01-16 23:33:39 UTC 
acm         2007-01-16 23:33:33 UTC

  FreeBSD ports repository

  Modified files:
    emulators/zsnes      Makefile distinfo 
  Added files:
    emulators/zsnes/files patch-configure 
  Removed files:
    emulators/zsnes/files patch-linux-zfilew.c 
  Log:
  - Update to 1.50
  - Added a few new OPTIONS knobs [1]
  - Distfile is now a .tar.bz2 instead of a .tar.gz
  - Target ALL wasn't valid
  - Removed substitutions to configure because they were unnessacary
  - Respect CFLAGS [1]
  - Mark IGNORE < 602000, It needs zlib 1.2.3 or greater [1]
  - Patch to linux/zfilew.c no longer needed
  
  PR:             ports/107125
  Submitted by:   Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)
  Reviewed by:    miwi and me [1]
  
  Revision  Changes    Path
  1.31      +26 -14    ports/emulators/zsnes/Makefile
  1.14      +3 -3      ports/emulators/zsnes/distinfo
  1.1       +41 -0     ports/emulators/zsnes/files/patch-configure (new)
  1.2       +0 -21     ports/emulators/zsnes/files/patch-linux-zfilew.c (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2007-01-16 23:34:19 UTC 
State Changed
From-To: feedback->closed

Committed with few modifications, thanks!!! :)