Bug 109434

Summary: Spamassassin Makefile needs gpg1. Patch makes it work with gpg2 also.
Product: Ports & Packages Reporter: Michele Possamai <possamai>
Component: Individual Port(s)Assignee: Rong-En Fan <rafan>
Status: Closed FIXED    
Severity: Affects Only Me CC: scheidell
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
spamass.diff
none
sapatch.diff none

Description Michele Possamai 2007-02-22 15:00:43 UTC 
/usr/ports/mail/p5-Mail-SpamAssassin checks for an executable gpgv.
If it does not exist it installs gnupg1. If you have gnupg2 installed, then the gpgv does not exist.
It is called gpgv2 then. SpamAssassin doesn't even use gpgv but just uses gpg which doesn't change it's name in gnupg2.
The patch changes the Makefile to check for gpg instead of gpgv.

How-To-Repeat: install gnupg2, then install spamassassin with gnupg support...
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-02-22 21:16:42 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Michael Scheidell 2007-02-23 17:19:57 UTC 
The following patch takes care of additional upwards compatibility 
issues when upgrading, reinstalling if different versions installed
dependency list looks like it WILL upgrade 4.11 to gpg 2.0 during a 
portupgrade -R p5-Mail-SpamAssassin.

doesn't force a upgrade to 2.0 if you just do a deinstall/reinstall for SA.

1) if no gpg installed, will install gpgv2 (which I have tested in 
FBSD5.5 and 4.11 and it works)
2) if gpg already installed, will use THAT one (which ever it is)

(thanks Michelle for original patch)

Mark Martinec (amavisd-new writer) sent me this and patch that fixes it.

This is wrong in Makefile:

.if defined(WITH_DOMAINKEYS) || defined(WITH_DKIM)
RUN_DEPENDS+=   p5-Mail-DomainKeys>=0.80:${PORTSDIR}/mail/p5-Mail-DomainKeys
.endif

Neither DKIM plugin nor the underlying Mail::DKIM module needs 
mail/p5-Mail-DomainKeys, the DK and DKIM plugins as well as underlying 
modules are completely independent.


Additionally, takefu sent information on a spamassassin bug patch that 
fixes sa-learn issue with stdin.

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5336
Comment 3 Rong-En Fan freebsd_committer freebsd_triage 2007-02-23 20:12:46 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->rafan

Eat.
Comment 4 Rong-En Fan freebsd_committer freebsd_triage 2007-02-24 09:01:09 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2007-02-24 09:01:10 UTC 
rafan       2007-02-24 09:01:03 UTC

  FreeBSD ports repository

  Modified files:
    mail/p5-Mail-SpamAssassin Makefile 
  Added files:
    mail/p5-Mail-SpamAssassin/files patch-sa-learn-raw 
  Log:
  - If there is no gnupg installed, install 2.x. If there is, use it. [1]
  - DKIM plugin and Mail::DKIM do not need Mail::DomainKeys [2]
  - Fix sa-learn with stdin [3]
    https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5336
  - Bump PORTREVISON
  
  PR:             ports/109434 [1]
  Submitted by:   Michele Possamai <possamai at xs4all.nl> [1],
                  Mark Martinec (amavisd-new writer) [2], takefu [3]
  Approved by:    Michael Scheidell <scheidell at secnap.net> (maintainer)
  
  Revision  Changes    Path
  1.105     +15 -4     ports/mail/p5-Mail-SpamAssassin/Makefile
  1.1       +14 -0     ports/mail/p5-Mail-SpamAssassin/files/patch-sa-learn-raw (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"