Bug 110060

Summary: [patch] ports/graphics/graphviz plugins do not work
Product: Ports & Packages Reporter: Helge Oldach <ports-graphviz-mar07>
Component: Individual Port(s)Assignee: Dirk Meyer <dinoex>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Helge Oldach 2007-03-07 22:30:07 UTC
Graphviz' plugins to not work, making most common graphics formats
inaccessible. For example:

# dot -Tpng
Renderer type: "png" not recognized. Use one of: dia dot fig hpgl mif mp pcl pic
# 

Some debugging revealed that the plugin loading is broken.
lib/gv/gvconfig.c references the Makefile's GVLIBDIR
build-time environment variable which is defined as
/usr/local/lib/graphviz/graphviz. (Note the double "graphviz".)
This directory doesn't exist, Actually the correct directory is
/usr/local/lib/graphviz (single "graphviz").

The root cause is an incomplete ${REINPLACE_CMD} in the ports' Makefile,
applied to lib/Makefile.in. While it is correct to amend libdir, we must
consequently rectify pkglibdir to avoid the double "graphviz". See the
patch below.

After application of the patch:

# dot -Twhatever
Renderer type: "whatever" not recognized. Use one of: canon cmap cmapx dia dot fig gd gd2 gif hpgl imap ismap jpeg jpg mif mp pcl pic plain plain-ext png ps ps2 svg svgz vrml vtx wbmp xdot
# 

While we're at it, ports/graphviz/files/patch-configure is an empty file
that should be removed.

Fix: rm ports/graphviz/files/patch-configure
How-To-Repeat: 
See above.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-03-07 22:30:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

Over to maintainer
Comment 2 dfilter service freebsd_committer freebsd_triage 2007-03-09 07:28:26 UTC
dinoex      2007-03-09 07:28:21 UTC

  FreeBSD ports repository

  Modified files:
    graphics/graphviz    Makefile pkg-plist 
  Removed files:
    graphics/graphviz/files patch-configure 
  Log:
  - fix plugin handling
  PR:             110060
  Submitted by:   Helge Oldach
  
  - add options TK ICONV XPM
  PR:             110060
  Submitted by:   Helge Oldach
  
  - avoid starting "-help"
  - fix pkg-plist after patches
  - fix default options
  - bump PORTREVISION
  
  Revision  Changes    Path
  1.75      +53 -17    ports/graphics/graphviz/Makefile
  1.5       +0 -0      ports/graphics/graphviz/files/patch-configure (dead)
  1.34      +2 -1      ports/graphics/graphviz/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 dfilter service freebsd_committer freebsd_triage 2007-03-09 07:28:27 UTC
dinoex      2007-03-09 07:28:21 UTC

  FreeBSD ports repository

  Modified files:
    graphics/graphviz    Makefile pkg-plist 
  Removed files:
    graphics/graphviz/files patch-configure 
  Log:
  - fix plugin handling
  PR:             110060
  Submitted by:   Helge Oldach
  
  - add options TK ICONV XPM
  PR:             110060
  Submitted by:   Helge Oldach
  
  - avoid starting "-help"
  - fix pkg-plist after patches
  - fix default options
  - bump PORTREVISION
  
  Revision  Changes    Path
  1.75      +53 -17    ports/graphics/graphviz/Makefile
  1.5       +0 -0      ports/graphics/graphviz/files/patch-configure (dead)
  1.34      +2 -1      ports/graphics/graphviz/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Dirk Meyer freebsd_committer freebsd_triage 2007-03-09 10:50:08 UTC
State Changed
From-To: open->closed

committed, thanks.