Summary: | start-dccifd chowns /var/run to user dcc | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Andy Hilker <ah> | ||||
Component: | Individual Port(s) | Assignee: | Tom McLaughlin <tmclaugh> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | ||||||
Priority: | Normal | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Andy Hilker
2007-03-27 20:30:06 UTC
State Changed From-To: open->feedback Awaiting maintainers feedback State Changed From-To: feedback->open maintainer feedback timeout Is the attached patch okay? I don't use this so please make sure it doesn't break anything. tom -- | tmclaugh at sdf.lonestar.org tmclaugh at FreeBSD.org | | FreeBSD http://www.FreeBSD.org | | BSD# http://www.mono-project.com/Mono:FreeBSD | State Changed From-To: open->feedback Responsible Changed From-To: freebsd-ports-bugs->tmclaugh Grab Can I get an approval on the patch attached to this PR? Since I don't use the port regularly I want to make sure I didn't break anything. Thanks. tom -- | tmclaugh at sdf.lonestar.org tmclaugh at FreeBSD.org | | FreeBSD http://www.FreeBSD.org | > Can I get an approval on the patch attached to this PR? Since I don't > use the port regularly I want to make sure I didn't break anything. > Thanks. > > tom I sent an email to the port maintainer about this a couple of weeks ago after tracking down why after upgrading DCC on my boxes Sendmail wouldn't restart because it claimed to not be running (/var/run was now owned by dcc(!) so Sendmail's mailnull user couldn't write a PID file in /var/run). I have not heard back. I was about to file a PR about this, but some searching turned up this PR. My configure_args line from the Makefile: CONFIGURE_ARGS= --homedir=${PREFIX}/dcc --bindir=${PREFIX}/bin --mandir=${MANPREFIX}/man --with-rundir=/var/run/dcc Other than there now being a ${MANPREFIX}, your patch is exactly what I came up with (change the configure args in the port Makefile so the run dir is /var/run/dcc and change the PID file location in the rc.d startup script to point to the new run directory), so I'll give it a personal thumbs up. The port (dcc-dccd-1.3.50) builds and runs correctly, and the dcc_conf file is correctly generated with the updated run dir. This simple issue has been unresolved for around 8 months now; what needs to be done to request a maintainer timeout and get the Makefile fixed? Craig. ------ State Changed From-To: feedback->closed Thanks for the thumbs up Craig. Patch has been committed. tmclaugh 2007-11-14 04:01:22 UTC FreeBSD ports repository Modified files: mail/dcc-dccd Makefile mail/dcc-dccd/files dcc-start.sh.in Log: Change location of pid file from /var/run to /var/run/dcc because application changes ownership of the rundir to the user it is running as. PR: 110943 Approved by: portmgr (linimon), maintainer timeout Revision Changes Path 1.36 +2 -1 ports/mail/dcc-dccd/Makefile 1.2 +1 -1 ports/mail/dcc-dccd/files/dcc-start.sh.in _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" |