Bug 111326

In the current version of ports/japanese/lynx (ja-lynx-2.8.4.rel1),
there are two problems about installation and deinstallation.

(1) First, if you run 'make install' in the port directory, a newly
    installed configulation file 'lynx.cfg' (not old one) is renamed
    to 'lynx.oldcfg' by mistake (and the another version of 'lynx.cfg'
    is installed later).

    This failure is occured by a wrong patch description (patch-aa).

    Then if you run 'make deinstall', the file 'lynx.oldcfg' is
    renamed to 'lynx.cfg' and leaved alone by the deinstall script
    described in pkg-plist.  This step is correct if the file
    'lynx.oldcfg' is a true backup file...

(2) If you install or deinstall the software from a binary package,
    that causes error messages due to the port's wrong pkg-plist
    lines:

$ cat -n /usr/ports/japanese/lynx/pkg-plist | head -n 6
     1 bin/lynx
     2 etc/lynx.cfg.sample
     3 @exec test -f %B/lynx.cfg && mv -f %B/lynx.cfg %B/lynx.oldcfg
     4 @exec cp -f %D/%F %B/lynx.cfg
     5 @unexec rm -f %B/lynx.cfg
     6 @unexec test -f %B/lynx.oldcfg && mv -f %B/lynx.oldcfg %B/lynx.cfg
$

    Whether the test(1) commands (in line 3 and 6) has failed or not,
    the aim of these lines are archived.

    But if the test(1) command has failed, pkg_add(8) and
    pkg_delete(8) commands outputs an error message.

Fix: * Fix these installation/deinstallation problems.
 * Update to the latest stable release (lynx2.8.6rel.4).
 * Remove patch-ab and patch-ad.  I've been tested lynx2.8.6 without
   the latter patch that is CJK specific. It seems that there is no
   problem.

The patch file (patch-aa), pkg-plist, and Makefile are based on
ports/www/lynx.
How-To-Repeat: # cd /usr/ports/japanese/lynx
# find /usr/local | sort > before-install.txt
# make TRYBROKEN=yes install package deinstall
===>   NOTICE:

This port is deprecated; you may wish to reconsider installing it:

Leaves behind config file on deinstall.

It is scheduled to be removed on or after 2007-04-10.

===>  Vulnerability check disabled, database not found
------------------------------------- snip -------------------------------------
===>  Installing for ja-lynx-2.8.4.rel1
===>   ja-lynx-2.8.4.rel1 depends on executable in : unzip - found
===>   ja-lynx-2.8.4.rel1 depends on executable in : zip - found
===>   Generating temporary packing list
===>  Checking if japanese/lynx already installed
mv -f /usr/local/bin/lynx /usr/local/bin/lynx.old
mv: rename /usr/local/bin/lynx to /usr/local/bin/lynx.old: No such file or direc
tory
*** Error code 1 (ignored)
install  -s -o root -g wheel -m 555 lynx /usr/local/bin/lynx
install  -o root -g wheel -m 444 ./lynx.man /usr/local/man/man1/lynx.1
mv -f /usr/local/etc/lynx.cfg /usr/local/etc/lynx.oldcfg
mv: rename /usr/local/etc/lynx.cfg to /usr/local/etc/lynx.oldcfg: No such file o
r directory
*** Error code 1 (ignored)
install  -o root -g wheel -m 444 ./lynx.cfg /usr/local/etc/lynx.cfg
------------------------------------- snip -------------------------------------
Updating /usr/local/etc/lynx.cfg
/bin/sh -c 'if test -f /usr/local/etc/lynx.cfg ; then  mv -f /usr/local/etc/lynx
.cfg /usr/local/etc/lynx.oldcfg ;  fi'
cp ./lynx.cfg /usr/local/etc/lynx.tmp
Updating /usr/local/etc/lynx.cfg to point to installed help-files
sed	-e '/^HELPFILE:http/s!^!#!'  -e '/^#HELPFILE:file/s!#!!'  -e '/^HELPFILE
:file/s!/PATH_TO/lynx_help!/usr/local/share/lynx_help!'  -e '/^[A-Z_]*:/s!/PATH_
TO/lynx_doc!/usr/local/share/doc/lynx!'  -e '/^HELPFILE:file/s!$!.gz!'  -e '/^HE
LPFILE:file/s!.gz.gz$!.gz!'  /usr/local/etc/lynx.tmp >/usr/local/etc/lynx.cfg
chmod 644 /usr/local/etc/lynx.cfg
cp -p /usr/local/etc/lynx.cfg /usr/local/etc/lynx.cfg.sample
rm -f /usr/local/etc/lynx.tmp
------------------------------------- snip -------------------------------------
===>  Building package for ja-lynx-2.8.4.rel1
Creating package /usr/ports/packages/All/ja-lynx-2.8.4.rel1.tbz
Registering depends: unzip-5.52_3 zip-2.32.
Creating bzip'd tar ball in '/usr/ports/packages/All/ja-lynx-2.8.4.rel1.tbz'
===>  Deinstalling for japanese/lynx
===>   Deinstalling ja-lynx-2.8.4.rel1
# find /usr/local | sort > after-deinstall.txt
# diff -u before-install.txt after-deinstall.txt 
--- before-install.txt	Fri Apr  6 18:08:42 2007
+++ after-deinstall.txt	Fri Apr  6 18:11:30 2007
@@ -1040,6 +1040,7 @@
 /usr/local/etc/kazehakase/smartbookmarks.xml
 /usr/local/etc/lftp.conf
 /usr/local/etc/lftp.conf.sample
+/usr/local/etc/lynx.cfg
 /usr/local/etc/mtree
 /usr/local/etc/mtree/BSD.gnome.dist
 /usr/local/etc/orbit2rc
# rm /usr/local/etc/lynx.cfg
# pkg_add /usr/ports/packages/All/ja-lynx-2.8.4.rel1.tbz 
pkg_add: command 'test -f /usr/local/etc/lynx.cfg && mv -f /usr/local/etc/lynx.c
fg /usr/local/etc/lynx.oldcfg' failed
# pkg_delete /var/db/pkg/ja-lynx-2.8.4.rel1/
pkg_delete: unexec command for 'test -f /usr/local/etc/lynx.oldcfg && mv -f /usr
/local/etc/lynx.oldcfg /usr/local/etc/lynx.cfg' failed
pkg_delete: couldn't entirely delete package (perhaps the packing list is
incorrectly specified?)
# find /usr/local | sort > after-pkg_delete.txt
# diff -u before-install.txt after-pkg_delete.txt 
#