Bug 111342

Summary: [patch] x11/slim theme parse error under 7-CURRENT
Product: Ports & Packages Reporter: Henrik Brix Andersen <henrik>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: ports
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch-cfg.cpp none

Description Henrik Brix Andersen 2007-04-07 03:50:04 UTC 
Since upgrading a work station to FreeBSD 7.0-CURRENT, x11/slim-1.2.6
parses all themes wrongly (all percentages are evaluated to
zero). This also applies to the default theme provided by slim itself.

I have tracked down this issue which seems to be caused by a stricter
gcc in 7-CURRENT compared to RELENG_6.

Fix: The patch below fixes this issue by eliminating the 'const char* tmp'
variable.

I have submitted the patch upstream for inclusion in the next release.

	
How-To-Repeat: Install x11/slim under 7-CURRENT and observe that the input panel is
wrongly placed at the top of the screen even though
/usr/local/share/slim/themes/default/slim.theme specifies non-zero
offsets (given in percent).
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-04-07 03:50:13 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Tobias Roth 2007-04-09 00:31:06 UTC 
Hi

Thanks for the patch. I am away from FreeBSD until mid of June, so I can't
test any patches. What I see looks good, please feel free to commit when
it satisfies your own tests. And thanks for submitting this upstream, the
people from slim are usually quite happy to receive patches.

Thanks a lot,
Tobias
Comment 3 Henrik Brix Andersen 2007-04-09 11:57:26 UTC 
I just received confirmation from the author of slim that my patch has
been accepted and will be part of the next release.

-- 
Henrik Brix Andersen <henrik@brixandersen.dk>
Comment 4 Rong-En Fan freebsd_committer freebsd_triage 2007-04-09 12:57:29 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2007-04-09 12:57:30 UTC 
rafan       2007-04-09 11:57:24 UTC

  FreeBSD ports repository

  Modified files:
    x11/slim             Makefile 
  Added files:
    x11/slim/files       patch-cfg.cpp 
  Log:
  - Fix theme parsing on 7.x. This patch is also accepted by upstream.
  
  PR:             ports/111342
  Submitted by:   Henrik Brix Andersen <henrik at brixandersen.dk>
  Approved by:    Tobias <ports at fsck.ch> (maintainer)
  
  Revision  Changes    Path
  1.7       +1 -0      ports/x11/slim/Makefile
  1.1       +12 -0     ports/x11/slim/files/patch-cfg.cpp (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"