Bug 111522

Summary:

Add support for the ofw bus interface to nexus

Product:

Base System

Reporter:

Andrew Turner <andrew>

Component:

powerpc

Assignee:

freebsd-ppc (Nobody) <ppc>

Status:

Closed FIXED

Severity:

Affects Only Me

Priority:

Normal

Version:

Unspecified

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
ppc-nexus-ofwbus.diff	none
freebsd-ppc-nexus-ofw.diff	none

Description Andrew Turner 2007-04-13 00:10:04 UTC

The attached patch adds support for the some of the ofw bus interface
to the nexus device.

Comment 1 Rink Springer freebsd_committer

2007-04-13 07:39:56 UTC

Hi Andrew,

On Fri, Apr 13, 2007 at 11:00:33AM +1200, Andrew Turner wrote:
> +	if ((dinfo = device_get_ivars(dev)) == 0)

style(9) says you should use NULL instead of 0. Other than this, I can't
see anything wrong with the patch.

Cheers,

-- 
Rink P.W. Springer                                - http://rink.nu
"It is such a quiet thing, to fall. But yet a far more terrible thing,
 to admit it."                                    - Darth Traya

Comment 2 Andrew Turner 2007-04-13 10:22:56 UTC

On Fri, 13 Apr 2007 08:39:56 +0200
Rink Springer <rink@FreeBSD.org> wrote:

> Hi Andrew,
> 
> On Fri, Apr 13, 2007 at 11:00:33AM +1200, Andrew Turner wrote:
> > +	if ((dinfo = device_get_ivars(dev)) == 0)
> 
> style(9) says you should use NULL instead of 0. Other than this, I
> can't see anything wrong with the patch.
> 
> Cheers,
> 
That line is a copy+paste from a similar line further up in the file.

I've attached a patch with the new code changed to NULL's.

Andrew

Comment 3 dfilter service freebsd_committer

2007-04-20 04:25:08 UTC

grehan      2007-04-20 03:24:59 UTC

  FreeBSD src repository

  Modified files:
    sys/powerpc/powerpc  nexus.c 
  Log:
  Add ofw bus methods to the ppc nexus driver. This will be used in future
  EFIKA platform support.
  
  PR:     111522
  Submitted by:   Andrew Turner, andrew at fubar geek nz
  
  Revision  Changes    Path
  1.14      +56 -0     src/sys/powerpc/powerpc/nexus.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 4 Mark Linimon freebsd_committer

2007-04-22 08:36:48 UTC

State Changed
From-To: open->closed

Committed by grehan on 2007-04-20.