Bug 111613

Summary: http://www.freebsd.org/send-pr.html will not post patch files
Product: Documentation Reporter: papowell
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description papowell 2007-04-15 15:30:01 UTC
When you try to submit a patch file AND you are using FireFox THEN  you get a 'bad file type' error message.

This is caused by the following lines in the web page:

 <label for="PATCH">And/or patch file (100KB max)</label>: <input id="PATCH" type="FILE"
name="patch" maxlength="102400" accept="text/*" /><br />

Firefox is a little too clever and determines that the MimeType is 'application/xxx'

Sigh... which it is...

Patrick ("Just when you think things cannot get worse, they get worse") Powell

Fix: 

I dunno...  Remove the type restriction?
Comment 1 Niclas Zeising 2007-04-15 20:31:28 UTC
Patrick Powell wrote:
>> Number:         111613
>> Category:       www
>> Synopsis:       http://www.freebsd.org/send-pr.html will not post patch files
>> Confidential:   no
>> Severity:       serious
>> Priority:       low
>> Responsible:    freebsd-www
>> State:          open
>> Quarter:        
>> Keywords:       
>> Date-Required:
>> Class:          sw-bug
>> Submitter-Id:   current-users
>> Arrival-Date:   Sun Apr 15 14:30:01 GMT 2007
>> Closed-Date:
>> Last-Modified:
>> Originator:     Patrick Powell
>> Release:        FreeBSD 6.2
>> Organization:
> Astart Technologies
>> Environment:
> FreeBSD astart.com 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Mon Mar 12 13:59:28 PDT 2007     root@laptop.private:/usr/src/sys/i386/compile/SMP  i386
>> Description:
> When you try to submit a patch file AND you are using FireFox THEN  you get a 'bad file type' error message.
> 
> This is caused by the following lines in the web page:
> 
>  <label for="PATCH">And/or patch file (100KB max)</label>: <input id="PATCH" type="FILE"
> name="patch" maxlength="102400" accept="text/*" /><br />
> 
> Firefox is a little too clever and determines that the MimeType is 'application/xxx'
> 
> Sigh... which it is...
> 
> Patrick ("Just when you think things cannot get worse, they get worse") Powell
>> How-To-Repeat:
> 
>> Fix:
> I dunno...  Remove the type restriction?
>> Release-Note:
>> Audit-Trail:

Just rename the file as *.txt, and it will work. It even says so in the 
descripton...
HTH
//Niclas
Comment 2 Remko Lodder freebsd_committer freebsd_triage 2007-04-15 22:17:44 UTC
Patrick Powell wrote:
>> Number:         111613
>> Category:       www
>> Synopsis:       http://www.freebsd.org/send-pr.html will not post patch files
>> Confidential:   no
>> Severity:       serious
>> Priority:       low
>> Responsible:    freebsd-www
>> State:          open
>> Quarter:        
>> Keywords:       
>> Date-Required:
>> Class:          sw-bug
>> Submitter-Id:   current-users
>> Arrival-Date:   Sun Apr 15 14:30:01 GMT 2007
>> Closed-Date:
>> Last-Modified:
>> Originator:     Patrick Powell
>> Release:        FreeBSD 6.2
>> Organization:
> Astart Technologies
>> Environment:
> FreeBSD astart.com 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Mon Mar 12 13:59:28 PDT 2007     root@laptop.private:/usr/src/sys/i386/compile/SMP  i386
>> Description:
> When you try to submit a patch file AND you are using FireFox THEN  you get a 'bad file type' error message.
> 
> This is caused by the following lines in the web page:
> 
>  <label for="PATCH">And/or patch file (100KB max)</label>: <input id="PATCH" type="FILE"
> name="patch" maxlength="102400" accept="text/*" /><br />
> 
> Firefox is a little too clever and determines that the MimeType is 'application/xxx'
> 
> Sigh... which it is...
> 
> Patrick ("Just when you think things cannot get worse, they get worse") Powell
>> How-To-Repeat:
> 
>> Fix:
> I dunno...  Remove the type restriction?
>> Release-Note:
>> Audit-Trail:
>> Unformatted:
> _______________________________________________
> freebsd-www@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-www
> To unsubscribe, send any mail to "freebsd-www-unsubscribe@freebsd.org"

This wont help, Devon submitted the check because the processing 
utilities only process text/* and not application/*. If some thing
explicitly sends the wrong data it will never get parsed and we will
needlessly let you think that you can submit this.

What you can do is copy/paste the patch inline or provide an URL
where the data can be read.

Thanks,
remko

-- 
Kind regards,

      Remko Lodder               ** remko@elvandar.org
      FreeBSD                    ** remko@FreeBSD.org

      /* Quis custodiet ipsos custodes */
Comment 3 Remko Lodder freebsd_committer freebsd_triage 2007-04-17 22:05:01 UTC
State Changed
From-To: open->closed

This will not get resolved since the form only accepts text/* input and 
nothing different. Best is to paste the diff in the comment window or 
place it on a public place to obtain (or send it privatly to the 
interested committer).