Bug 112321

Summary: [maintainer-update] comms/obexapp - fix build when readline-5.2 is installed
Product: Ports & Packages Reporter: Guido Falsi <madpilot>
Component: Individual Port(s)Assignee: Martin Matuska <mm>
Status: Closed FIXED    
Severity: Affects Only Me CC: paulbeard
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
obexapp-1.4.6_1.diff none

Description Guido Falsi freebsd_committer freebsd_triage 2007-05-01 19:30:04 UTC 
Port fails to build when the readline 5.2 port is installed due to a conflict in include files. Following patch fixes that.

Reported By: Paul Beard
Comment 1 Martin Matuska freebsd_committer freebsd_triage 2007-05-03 12:16:43 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mm

I'll take it.
Comment 2 Martin Matuska freebsd_committer freebsd_triage 2007-05-03 13:42:08 UTC 
Hello, I have found out that your port was not LOCALBASE compliant and
the NO_INSTALL_MANPAGES knob was missing.
With the CFLAGS you are adding, the replacement part in Makefile is not
required anymore. I have added a NO_WERROR option to MAKE_ENV so that
obexapp builds on FreeBSD 5.5.

Updated patch is attached. If you agree, I will commit it.

I have checked the updated patch on tinderbox.

Logs:
http://i386.vx.sk/logs/6.2-FreeBSD-i386/obexapp-1.4.6_1.log
http://i386.vx.sk/logs/5.5-FreeBSD-i386/obexapp-1.4.6_1.log
http://i386.vx.sk/logs/7-FreeBSD-i386/obexapp-1.4.6_1.log
http://amd64.vx.sk/logs/6.2-FreeBSD-amd64/obexapp-1.4.6_1.log
http://amd64.vx.sk/logs/5.5-FreeBSD-amd64/obexapp-1.4.6_1.log
http://amd64.vx.sk/logs/7-FreeBSD-amd64/obexapp-1.4.6_1.log
Comment 3 Martin Matuska freebsd_committer freebsd_triage 2007-05-03 14:11:09 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2007-05-03 19:50:15 UTC 
On Thu, May 03, 2007 at 02:42:08PM +0200, Martin Matuska wrote:
> Hello, I have found out that your port was not LOCALBASE compliant and
> the NO_INSTALL_MANPAGES knob was missing.
> With the CFLAGS you are adding, the replacement part in Makefile is not
> required anymore. I have added a NO_WERROR option to MAKE_ENV so that
> obexapp builds on FreeBSD 5.5.
> 
> Updated patch is attached. If you agree, I will commit it.
> 
> I have checked the updated patch on tinderbox.
> 
> Logs:
> http://i386.vx.sk/logs/6.2-FreeBSD-i386/obexapp-1.4.6_1.log
> http://i386.vx.sk/logs/5.5-FreeBSD-i386/obexapp-1.4.6_1.log
> http://i386.vx.sk/logs/7-FreeBSD-i386/obexapp-1.4.6_1.log
> http://amd64.vx.sk/logs/6.2-FreeBSD-amd64/obexapp-1.4.6_1.log
> http://amd64.vx.sk/logs/5.5-FreeBSD-amd64/obexapp-1.4.6_1.log
> http://amd64.vx.sk/logs/7-FreeBSD-amd64/obexapp-1.4.6_1.log
> 

Very good work, thank you for your help!

I looke at the patch and tried it and it's ok for me. The logs you
provide are even better proof for that.

Ok to commit. And thank you again!

-- 
Guido Falsi <mad@madpilot.net>
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2007-05-12 11:16:45 UTC 
State Changed
From-To: feedback->open

Maintainer approved
Comment 6 dfilter service freebsd_committer freebsd_triage 2007-05-25 11:50:53 UTC 
mm          2007-05-25 10:50:47 UTC

  FreeBSD ports repository

  Modified files:
    comms/obexapp        Makefile 
    comms/obexapp/files  patch-Makefile 
  Log:
  - counterpatch proposed by mm@ (maintainer approved)
  - fixed build on i386 if devel/readline installed
  - fixed build on FreeBSD 5.5
  - added NO_INSTALL_MANPAGES knob
  
  PR:             ports/112321
  Approved by:    garga (mentor)
  
  Revision  Changes    Path
  1.15      +10 -6     ports/comms/obexapp/Makefile
  1.9       +17 -5     ports/comms/obexapp/files/patch-Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Martin Matuska freebsd_committer freebsd_triage 2007-05-25 12:00:50 UTC 
State Changed
From-To: open->closed

Commited with modifications, thanks!