Bug 112668

Summary: [ports][Xorg7.2][graphics/mesa-demos] Broken for non-nvidia drivers.
Product: Base System Reporter: Dominic Fandrey <LoN_Kamikaze>
Component: miscAssignee: Marcelo Araujo <araujo>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Dominic Fandrey 2007-05-14 22:10:03 UTC 
There's a patch in files that introduces an #ifdef for WITH_NVIDIA_GL. Unfortunately the ports Makefile sets WITH_NVIDIA_GL=0 if it is not defined and thus triggers the #ifdef as well.

also the #ifdef is followed by an #elif without parameters, so it's still broken after fixing the makefile. The #elif has to be replaced with #else.

How-To-Repeat: Just try to build without NVIDIA and you will see that it attempts to build for NVIDIA anyway (it will miss a function ending with NV, which should end with MESA).
Comment 1 Marcelo Araujo freebsd_committer freebsd_triage 2007-05-15 11:31:07 UTC 
Responsible Changed
From-To: freebsd-bugs->araujo

I'll take it.
Comment 2 Marcelo Araujo freebsd_committer freebsd_triage 2007-05-15 13:09:07 UTC 
State Changed
From-To: open->closed

Fixed by flz@.