Bug 113065

Summary: [Patch]: graphics/mesa-demos: Add linking against pthread
Product: Ports & Packages Reporter: Marcus von Appen <mva>
Component: Individual Port(s)Assignee: Marcelo Araujo <araujo>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Marcus von Appen freebsd_committer freebsd_triage 2007-05-27 20:40:04 UTC 
The latest graphics/mesa-demos got the -DPTHREAD flag, but misses to link against -pthread. The attached patch fixes this.

How-To-Repeat: Try to compile mesa-demos:

[...]
gmake[1]: Leaving directory `/usr/ports/graphics/mesa-demos/work/Mesa-6.5.3/progs/demos'
gmake[1]: Entering directory `/usr/ports/graphics/mesa-demos/work/Mesa-6.5.3/progs/xdemos'
cc -I../../include -fPIC -pedantic -I/usr/local/include -DUSE_XSHM -DHZ=100 -O2 -pipe -march=pentium4 -DPTHREADS glthreads.c -L/usr/local/lib -lglut -lGLU -lGL -lXext -lXmu -lXi -lX11 -lm -o glthreads
/usr/bin/ld: warning: libm.so.3, needed by /usr/local/lib/libGL.so, may conflict with libm.so.4
/var/tmp//ccF8K72R.o(.text+0xca0): In function `main':
: undefined reference to `pthread_create'
/var/tmp//ccF8K72R.o(.text+0xd8e): In function `main':
: undefined reference to `pthread_join'
gmake[1]: *** [glthreads] Error 1
gmake[1]: Leaving directory `/usr/ports/graphics/mesa-demos/work/Mesa-6.5.3/progs/xdemos'
gmake: *** [default] Error 1
*** Error code 2
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-05-27 20:40:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->araujo

Over to maintainer
Comment 2 Marcus von Appen freebsd_committer freebsd_triage 2007-05-27 20:59:50 UTC 
Of course it must be -pthread, not -lpthread.

Regards
Marcus
Comment 3 Stanislav Sedov freebsd_committer freebsd_triage 2007-05-29 06:21:50 UTC 
A small note:
there're a variables like PTHREAD_LIBS and PTHREAD_CFLAGS in
bsd.port.mk, use them instead of direct passing.

-- 
Stanislav Sedov
ST4096-RIPE
Comment 4 Eric Anholt freebsd_committer freebsd_triage 2007-05-29 20:15:37 UTC 
State Changed
From-To: open->closed

Fixed this one without noticing the PR.