Bug 113133

Summary: Add PDCM bit name to CPU Features2
Product: Base System Reporter: Pankov Pavel <pankov_p>
Component: i386Assignee: Dag-Erling Smørgrav <des>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 6.0-RELEASE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Pankov Pavel 2007-05-29 18:50:03 UTC 
According to "Intel® 64 and IA-32 Architectures Software Developer's Manual Volume 2A: Instruction Set Reference, A-M" (http://developer.intel.com/design/processor/manuals/253666.pdf) the PDCM bit name in extended CPU features displaying code in -CURRENT is missing. Attached patch fixes it. This bit is set, for example, in my Core 2 Duo T5600.

Also, RELENG_6 lacks names for SMX, SSSE3, xTPR, PDCM bits. I think they can be MFC'd safely and easily.

Fix: Apply the attached patch to -CURRENT (can also be downloaded here: http://www.pankov.pp.ru/patches/identcpu-PDCM.diff).

Patch attached with submission follows:
How-To-Repeat: Boot on the CPU that has highlighted bits set.
Comment 1 Dag-Erling Smørgrav freebsd_committer freebsd_triage 2007-05-29 20:05:43 UTC 
Responsible Changed
From-To: freebsd-i386->des

Low-hanging fruit
Comment 2 dfilter service freebsd_committer freebsd_triage 2007-05-29 20:21:59 UTC 
des         2007-05-29 19:21:53 UTC

  FreeBSD src repository

  Modified files:
    sys/i386/i386        identcpu.c 
  Log:
  Add feature name for features2 bit 15.
  
  PR:             i386/113133
  Submitted by:   Pankov Pavel <pankov_p@mail.ru>
  MFC after:      3 days
  
  Revision  Changes    Path
  1.178     +1 -1      src/sys/i386/i386/identcpu.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Dag-Erling Smørgrav freebsd_committer freebsd_triage 2007-05-29 20:26:23 UTC 
State Changed
From-To: open->patched

Awaiting MFC
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2008-02-28 21:54:50 UTC 
State Changed
From-To: patched->suspended

This is now in 6.x and 7.0.  When 5.x goes EOL we'll just close it (EOL 
is in a few months).
Comment 5 Bruce Cran freebsd_committer freebsd_triage 2008-12-25 21:22:54 UTC 
State Changed
From-To: suspended->closed

5.x has gone EOL.