Bug 113216

Summary: [PATCH] net/rdesktop: fix segfault at login using xorg 7.2
Product: Ports & Packages Reporter: Thomas Spreng <spreng>
Component: Individual Port(s)Assignee: David E. O'Brien <obrien>
Status: Closed FIXED    
Severity: Affects Only Me CC: obrien
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
rdesktop-1.5.0_2.diff none

Description Thomas Spreng 2007-06-01 12:10:03 UTC 
rdesktop may segfault due to Xlib sanity checking of arguments passed to XCreateImage(3) if using xorg 7.2.
This patch is based on a PR from Ubuntu concerning the same problem: 
https://bugs.launchpad.net/ubuntu/+source/rdesktop/+bug/104332

I've tested the patch with a connection to a Windows 2003 SP2 Terminal Server with all color depth's, fullscreen and window mode.

How-To-Repeat: 	
Try to log into Windows 2003 SP2 (not sure about other versions) using rdesktop 1.5.0_1 and xorg 7.2.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-06-01 12:10:12 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->obrien

Over to maintainer
Comment 2 Thomas Spreng 2007-06-02 12:50:15 UTC 
apparently, this segfault only occurs when xorg runs with a color depth 
of 24, as described here:
http://www.freebsd.org/cgi/getmsg.cgi?fetch=857354+0+current/freebsd-ports

hope this helps somehow.

cheers.

-- 
Thomas Spreng <spreng@iam.unibe.ch>
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2007-06-19 09:53:41 UTC 
State Changed
From-To: open->closed

Committed, thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-06-19 09:55:18 UTC 
pav         2007-06-19 08:55:11 UTC

  FreeBSD ports repository

  Modified files:
    net/rdesktop         Makefile 
  Added files:
    net/rdesktop/files   patch-xwin.c 
  Log:
  - Fix a crash on login for people running on X.org 7.2 in 24-bit color depth
  
  PR:             ports/113216, ports/113678
  Submitted by:   Thomas Spreng <spreng@socket.ch>
  Approved by:    maintainer timeout (obrien; 18 days)
  
  Revision  Changes    Path
  1.41      +1 -1      ports/net/rdesktop/Makefile
  1.1       +11 -0     ports/net/rdesktop/files/patch-xwin.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"