Bug 113249

Summary: [patch] emulators/vba PROFILING knob uses wrong configure argument
Product: Ports & Packages Reporter: Dylan Leigh <dleigh>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Dylan Leigh 2007-06-02 13:00:10 UTC 
VBA's configure enables profiling by default; the ports makefile adds "--without-profiling" if "PROFILING" is not set, but the correct argument to disable it is "--disable-profiling" so profiling will be enabled regardless.

Fix: 

.ifndef(PROFILING)
-CONFIGURE_ARGS+=       --without-profiling
+CONFIGURE_ARGS+=       --disable-profiling
 .endif

 pre-everything::--7wprKfPAbdLg0KK0GrrolKNOSJX1YbI1w60oyiS34Y1cM2iL
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- /root/vba.Makefile.old      Sat Jun  2 21:17:06 2007
+++ Makefile    Sat Jun  2 21:30:56 2007
@@ -54,7 +54,7 @@
 .endif
How-To-Repeat: cd /usr/ports/emulators/vba/
make build
[vba will build with profiling enabled (-DPROFILING)]
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-06-02 13:00:20 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 dfilter service freebsd_committer freebsd_triage 2007-06-22 15:25:34 UTC 
rafan       2007-06-22 14:25:27 UTC

  FreeBSD ports repository

  Modified files:
    emulators/vba        Makefile 
  Log:
  - Use correct argument to disable profiling
  
  PR:           ports/113249
  Submitted by: Dylan Leigh <dleigh at cs.rmit.edu.au>
  Approved by:  maintainer timeout (20 days)
  
  Revision  Changes    Path
  1.21      +1 -1      ports/emulators/vba/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Rong-En Fan freebsd_committer freebsd_triage 2007-06-22 15:25:36 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!