Bug 113986

Summary: [patch] [acpi] viapm.ko kernel module incorrectly reprograms SMBus base address, thereby causing a hang on the ASUS A7V when trying to shutdown -p
Product: Base System Reporter: Martin Birgmeier <martin>
Component: kernAssignee: freebsd-acpi (Nobody) <acpi>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 6.2-RELEASE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Martin Birgmeier 2007-06-24 12:20:01 UTC
	The Makefile for the viapm.ko kernel module (at
	sys/modules/i2c/controllers/viapm/Makefile) sets

	    CFLAGS         += -DVIAPM_BASE_ADDR=0x6000

	which breaks the power-off function (shutdown -p) on my ASUS A7V
	motherboard.

	The reason for the latter is that the ACPI \_SI.SST method of
	the A7V bios only knows about the standard base address of the
	SMBus controller (0xe800). If the controller suddenly appears
	at another address, "empty space" will be read, causing an
	infinite loop while executing the method during acpi_shutdown_final()
	in sys/dev/acpica/acpi.c.

	This fixes i386/97468.

	p.s. The e-mail address is bogus as I am paranoid of junk mail.
	Please reply via adding to the PR.

How-To-Repeat: 	Use FreeBSD source as is. :-)
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2007-06-24 16:27:25 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-acpi

Over to maintainer(s).
Comment 2 dfilter service freebsd_committer freebsd_triage 2007-06-24 21:36:05 UTC
njl         2007-06-24 20:35:59 UTC

  FreeBSD src repository

  Modified files:
    sys/modules/i2c/controllers/alpm Makefile 
    sys/modules/i2c/controllers/viapm Makefile 
  Log:
  The viapm module build had what appear to be some debugging CFLAGS left
  around to force the IO port to a fixed address.  They were only turned
  on in the module build and were present since the original import.  This
  breaks soft power-off on the Asus A7V since it reprograms the SMBus base
  address to a different one than the BIOS expects.  A similar issue was
  found in the alpm(4) module build.
  
  PR:             kern/113986, i386/97468
  MFC after:      3 days
  Approved by:    re
  
  Revision  Changes    Path
  1.2       +0 -1      src/sys/modules/i2c/controllers/alpm/Makefile
  1.3       +0 -1      src/sys/modules/i2c/controllers/viapm/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 njl freebsd_committer freebsd_triage 2007-06-25 00:47:10 UTC
State Changed
From-To: open->closed

Fix committed, thank you very much for your debugging effort.