Bug 114139
| Summary: | mbuf(9) has misleading comments on M_DONTWAIT and M_TRYWAIT | ||
|---|---|---|---|
| Product: | Documentation | Reporter: | James Gritton <jamie> |
| Component: | Manual Pages | Assignee: | freebsd-bugs (Nobody) <bugs> |
| Status: | Closed Overcome By Events | ||
| Severity: | Affects Only Me | CC: | arkr17997, doc, mhorne |
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
Hi, I'm not completely sure on the first point, I think the missing context not copied from mbuf(9) does point out why they are different. Compare mbuf.9 to sys/mbuf.h and double check. For the second point, I sent this patch to another developer for review: Index: mbuf.9 =================================================================== RCS file: /home/ncvs/src/share/man/man9/mbuf.9,v retrieving revision 1.65 diff -u -u -r1.65 mbuf.9 --- mbuf.9 26 Feb 2007 15:17:19 -0000 1.65 +++ mbuf.9 22 Jan 2008 11:52:59 -0000 @@ -24,7 +24,7 @@ .\" .\" $FreeBSD: src/share/man/man9/mbuf.9,v 1.65 2007/02/26 15:17:19 bms Exp $ .\" -.Dd February 26, 2007 +.Dd January 22, 2008 .Dt MBUF 9 .Os .\" @@ -363,12 +363,8 @@ .Fa how is set to .Dv M_TRYWAIT , -a failed allocation will result in the caller being put -to sleep for a designated -kern.ipc.mbuf_wait -.Xr ( sysctl 8 -tunable) -number of ticks. +a failed allocation will result in the caller blocking until +resources are available and thus never return NULL. A number of other functions and macros related to .Vt mbufs have the same argument because they may Thanks, -- Tom Rhodes For bugs matching the following criteria: Status: In Progress Changed: (is less than) 2014-06-01 Reset to default assignee and clear in-progress tags. Mail being skipped MARKED AS SPAM Looks like both of these flags have long been retired in favor of the standard M_NOWAIT and M_WAITOK; no references remain in the src tree. This can safely be closed. |
The MGET section of mbuf(9) asserts that M_DONTWAIT shouldn't be confused with M_NOWAIT ("they are not the same"). In sys/mbuf.h, they are in fact the same, as M_DONTWAIT is merely defined as M_NOWAIT. Also, M_TRYWAIT is said to wait for kern.ipc.mbuf_wait ticks, a tunable which apparently no longer exists (and really M_TRYWAIT is just M_WAITOK).